Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Support First and Last aggregators in Substrait #35506

Closed
rtpsw opened this issue May 9, 2023 · 2 comments · Fixed by #35513
Closed

[C++] Support First and Last aggregators in Substrait #35506

rtpsw opened this issue May 9, 2023 · 2 comments · Fixed by #35513
Assignees
@rtpsw
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@rtpsw
Copy link
Contributor

rtpsw commented May 9, 2023

Describe the enhancement requested

Currently, Ibis-Substrait defines First and Last aggregators while Arrow-Substrait does not support them. This issue will add the support.

Component(s)

C++
@rtpsw
Copy link
Contributor Author

rtpsw commented May 9, 2023

take

@rtpsw
Copy link
Contributor Author

rtpsw commented May 9, 2023

cc @westonpace, @icexelloss

rtpsw added a commit to rtpsw/arrow that referenced this issue May 9, 2023
@rtpsw
apacheGH-35506: Support First and Last aggregators in Substrait
66dd40d
@rtpsw rtpsw mentioned this issue May 9, 2023
Merged
rtpsw added a commit to rtpsw/arrow that referenced this issue May 17, 2023
@rtpsw
apacheGH-35506: [C++] Support First and Last aggregators in Substrait
5208ee2
icexelloss pushed a commit that referenced this issue May 17, 2023
@rtpsw
GH-35506: [C++] Support First and Last aggregators in Substrait (#35513)
04c49d0 
### Rationale for this change

See #35506

### What changes are included in this PR?

"first" and "last" are registered as aggregates in Substrait.

### Are these changes tested?

Yes, The test-cases cover grouped and non-grouped aggregation with "first" and "last", as well as "null" and non-"null" outputs.

### Are there any user-facing changes?

Yes, "first" and "last" will be valid in a consumed Substrait plan.
* Closes: #35506

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
@icexelloss icexelloss added this to the 13.0.0 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtpsw rtpsw

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35506: [C++] Support First and Last aggregators in Substrait rtpsw/arrow
2 participants
@icexelloss @rtpsw