Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][C++] arrow::internal::IsNullRunEndEncoded redeclared #35526

Closed
mapleFU opened this issue May 10, 2023 · 0 comments · Fixed by #35527
Closed

[CI][C++] arrow::internal::IsNullRunEndEncoded redeclared #35526

mapleFU opened this issue May 10, 2023 · 0 comments · Fixed by #35527

Comments

@mapleFU
Copy link
Member

mapleFU commented May 10, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Error messages would be like:

D:/a/arrow/arrow/cpp/src/arrow/array/data.h:530:15: warning: 'bool arrow::internal::IsNullRunEndEncoded(const arrow::ArrayData&, int64_t)' redeclared without dllimport attribute after being referenced with dll linkage
  530 |   friend bool internal::IsNullRunEndEncoded(const ArrayData& span, int64_t i);
      |               ^~~~~~~~
[122/131] Linking CXX shared library release\libparquet.dll
[123/131] Linking CXX shared library release\libarrow_dataset.dll
[124/131] Linking CXX shared library release\libarrow_substrait.dll
[125/131] Building CXX object src/gandiva/CMakeFiles/gandiva_shared.dir/Unity/unity_4_cxx.cxx.obj
In file included from D:/a/arrow/arrow/cpp/src/arrow/array/array_base.h:26,
                 from D:/a/arrow/arrow/cpp/src/arrow/array.h:41,
                 from D:/a/arrow/arrow/cpp/src/gandiva/arrow.h:23,
                 from D:/a/arrow/arrow/cpp/src/gandiva/simple_arena.h:27,
                 from D:/a/arrow/arrow/cpp/src/gandiva/execution_context.h:22,
                 from D:/a/arrow/arrow/cpp/src/gandiva/interval_holder.h:27,
                 from D:/a/arrow/arrow/cpp/src/gandiva/interval_holder.cc:18,
                 from D:/a/arrow/arrow/build/cpp/src/gandiva/CMakeFiles/gandiva_shared.dir/Unity/unity_4_cxx.cxx:3:
D:/a/arrow/arrow/cpp/src/arrow/array/data.h:530:15: warning: 'bool arrow::internal::IsNullRunEndEncoded(const arrow::ArrayData&, int64_t)' redeclared without dllimport attribute after being referenced with dll linkage
  530 |   friend bool internal::IsNullRunEndEncoded(const ArrayData& span, int64_t i);
      |               ^~~~~~~~
In file included from D:/a/arrow/arrow/build/cpp/src/gandiva/CMakeFiles/gandiva_shared.dir/Unity/unity_4_cxx.cxx:5:
D:/a/arrow/arrow/cpp/src/gandiva/llvm_generator.cc: In member function 'arrow::Status gandiva::LLVMGenerator::CodeGenExprValue(gandiva::DexPtr, int, gandiva::FieldDescriptorPtr, int, std::string&, gandiva::SelectionVector::Mode)':
D:/a/arrow/arrow/cpp/src/gandiva/llvm_generator.cc:362:27: warning: 'selection_vector_type' may be used uninitialized [-Wmaybe-uninitialized]
  362 |         builder->CreateGEP(selection_vector_type, arg_selection_vector, loop_var);
      |         ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D:/a/arrow/arrow/cpp/src/gandiva/llvm_generator.cc:282:15: note: 'selection_vector_type' was declared here
  282 |   llvm::Type* selection_vector_type;
      |               ^~~~~~~~~~~~~~~~~~~~~

See https://github.com/apache/arrow/actions/runs/4935627139/jobs/8822177881?pr=35520 and https://github.com/apache/arrow/actions/runs/4926681476/jobs/8802598792?pr=35428

Personally I guess it was introduced in fde31ed

Component(s)

C++, Continuous Integration

pitrou pushed a commit that referenced this issue May 11, 2023
…lared (#35527)

### Rationale for this change

Fixing arrow::internal::IsNullRunEndEncoded redeclared. The CI will report:

```
'bool arrow::internal::IsNullRunEndEncoded(const arrow::ArrayData&, int64_t)' redeclared without dllimport attribute after being referenced with dll linkage
```

And:

```
warning: 'selection_vector_type' may be used uninitialized
```

### What changes are included in this PR?

1. Add `ARROW_FRIEND_EXPORT` for friend function
2. Initialize pointer in gandiva with `nullptr`

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: #35526

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 13.0.0 milestone May 11, 2023
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
… redeclared (apache#35527)

### Rationale for this change

Fixing arrow::internal::IsNullRunEndEncoded redeclared. The CI will report:

```
'bool arrow::internal::IsNullRunEndEncoded(const arrow::ArrayData&, int64_t)' redeclared without dllimport attribute after being referenced with dll linkage
```

And:

```
warning: 'selection_vector_type' may be used uninitialized
```

### What changes are included in this PR?

1. Add `ARROW_FRIEND_EXPORT` for friend function
2. Initialize pointer in gandiva with `nullptr`

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: apache#35526

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
… redeclared (apache#35527)

### Rationale for this change

Fixing arrow::internal::IsNullRunEndEncoded redeclared. The CI will report:

```
'bool arrow::internal::IsNullRunEndEncoded(const arrow::ArrayData&, int64_t)' redeclared without dllimport attribute after being referenced with dll linkage
```

And:

```
warning: 'selection_vector_type' may be used uninitialized
```

### What changes are included in this PR?

1. Add `ARROW_FRIEND_EXPORT` for friend function
2. Initialize pointer in gandiva with `nullptr`

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: apache#35526

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants