Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Arrow 12 cpp doesn't compile with protobuf 23.0 #35538

Closed
smahapatra1 opened this issue May 10, 2023 · 1 comment
Closed

[C++] Arrow 12 cpp doesn't compile with protobuf 23.0 #35538

smahapatra1 opened this issue May 10, 2023 · 1 comment
Assignees
@felipecrv
Labels
Component: C++ Component: FlightRPC good-first-issue Type: bug
Milestone
12.0.1

Comments

@smahapatra1
Copy link

Describe the bug, including details regarding any error messages, version, and platform.

cpp/src/arrow/engine/substrait/serde.cc:27:10: fatal error: google/protobuf/stubs/status.h: No such file or directory
27 | #include <google/protobuf/stubs/status.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Component(s)

C++, FlightRPC
@westonpace westonpace changed the title Arrow 12 cpp doesn't compile with protobuf 23.0 [C++] Arrow 12 cpp doesn't compile with protobuf 23.0 May 11, 2023
@felipecrv felipecrv mentioned this issue May 18, 2023
Merged
westonpace pushed a commit that referenced this issue May 18, 2023
@felipecrv
GH-35538: [C++] Remove unnecessary status.h include from protobuf (#3…
b80c655 
…5673)

### Rationale for this change

Newer versions of protobuf use `absl::Status` instead of `google::protobuf::util::Status`. The status variables in this file are type-annotated with `auto` and we can count on the header that declares the status-returning function we are calling to have included the header that defines `Status`.

### What changes are included in this PR?

Removing an include of a protobuf header that don't exist in later versions of the library.

### Are these changes tested?

I haven't tried building with protobuf 23, but I can be sure this specifically fixes the problem reported in #35538.

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@westonpace westonpace added this to the 13.0.0 milestone May 18, 2023
@westonpace
Copy link
Member

Issue resolved by pull request 35673
#35673

@felipecrv felipecrv modified the milestones: 13.0.0, 12.0.1 May 19, 2023
raulcd pushed a commit that referenced this issue May 30, 2023
@felipecrv @raulcd
GH-35538: [C++] Remove unnecessary status.h include from protobuf (#3…
d151bdb 
…5673)

### Rationale for this change

Newer versions of protobuf use `absl::Status` instead of `google::protobuf::util::Status`. The status variables in this file are type-annotated with `auto` and we can count on the header that declares the status-returning function we are calling to have included the header that defines `Status`.

### What changes are included in this PR?

Removing an include of a protobuf header that don't exist in later versions of the library.

### Are these changes tested?

I haven't tried building with protobuf 23, but I can be sure this specifically fixes the problem reported in #35538.

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@h-vetinari h-vetinari mentioned this issue Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Component: FlightRPC good-first-issue Type: bug
Projects
None yet
Milestone
12.0.1
Development

No branches or pull requests
3 participants
@felipecrv @westonpace @smahapatra1