Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Arrow 12.0.0-1 cpp exposes internal headers #35539

Closed
marsupialtail opened this issue May 10, 2023 · 6 comments · Fixed by #35592
Closed

[C++] Arrow 12.0.0-1 cpp exposes internal headers #35539

marsupialtail opened this issue May 10, 2023 · 6 comments · Fixed by #35592
Assignees
Milestone

Comments

@marsupialtail
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

it exposes compute/key_map.h.
However, compute/key_map.h relies on compute/util_internal.h which is not exposed.

Ubuntu

Component(s)

C++

@westonpace westonpace changed the title Arrow 12.0.0-1 cpp dev issues [C++] Arrow 12.0.0-1 cpp exposes internal headers May 10, 2023
@kou kou added this to the 12.0.1 milestone May 11, 2023
@kou
Copy link
Member

kou commented May 11, 2023

Oh...
This was introduced by #34518.

@LDipo Could you fix this?
(Cc: Reviewers: @icexelloss @westonpace )

We may want to add a lint check or something that detects private/internal headers includes from public headers.

@icexelloss
Copy link
Contributor

Thanks @kou. Let me ping @ildipo and see if he can take a look.

@icexelloss
Copy link
Contributor

@ildipo is out Today and he says he will take a look Monday

@kou
Copy link
Member

kou commented May 12, 2023

Thanks! (And sorry for my wrong mention...)

@ildipo
Copy link
Contributor

ildipo commented May 15, 2023

on it

@ildipo
Copy link
Contributor

ildipo commented May 15, 2023

take

pitrou added a commit that referenced this issue May 16, 2023
…r file (#35592)

### What changes are included in this PR?

Remove use of compute/util_internal.h in compute/key_map.h

* Closes: #35539

Lead-authored-by: Davide Pasetto <dpasetto69@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou modified the milestones: 12.0.1, 13.0.0 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants