[Java] unwrap() in NettyArrowBuf causes breaks when debug / error messages are logged

[martin-traverse]

Describe the bug, including details regarding any error messages, version, and platform.

The implementation of NettyArrowBuf unwrap() is throwing UnsupportedOperationException, but the ByteBuf interface says unwrap() should return null when a buffer cannot be unwrapped. Netty's AbstractByteBuf base class calls unwrap() in toString() and prints extra info if the result is non-null. Since toString() is called every time a debug or error message is printed, real errors are getting masked and enabling debug logging is likely to cause unexpected errors.

Seems like a simple fix just to return null from unwrap() in NettyArrowBuf? I will submit a PR with the change if someone wants to take a look.

Component(s)

Java

[martin-traverse]

A couple of references

• ByteBuf unwrap()
• AbstractByteBuf toString()