[Java] NullVector returning an inconsistent hash for null values between vectors #35588
Comments
|
Huh. Yeah, it should be a constant. |
lidavidm
changed the title
|
A quick PR would be welcome, or @davisusanibar would you be able to take a look? |
|
Hey @lidavidm - yep, have raised a PR. Don't think I've got my environment set up completely in order to run the later module tests, but the vector module passed. James |
lidavidm
pushed a commit
that referenced
this issue
May 15, 2023
#35588 (#35590) resolves #35588 ### Are these changes tested? I've run `mvn test` locally, and got the following: ``` [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestTls.connectTls:43->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [ERROR] TestTls.connectTlsDisableServerVerification:93->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [ERROR] TestTls.rejectHostname:76->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [ERROR] TestTls.rejectInvalidCert:61->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [INFO] [ERROR] Tests run: 108, Failures: 0, Errors: 4, Skipped: 20 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache Arrow Java Root POM 11.0.0: [INFO] [INFO] Apache Arrow Java Root POM ......................... SUCCESS [ 6.392 s] [INFO] Arrow Format ....................................... SUCCESS [ 2.151 s] [INFO] Arrow Memory ....................................... SUCCESS [ 2.000 s] [INFO] Arrow Memory - Core ................................ SUCCESS [ 3.617 s] [INFO] Arrow Memory - Unsafe .............................. SUCCESS [ 2.478 s] [INFO] Arrow Memory - Netty ............................... SUCCESS [ 3.567 s] [INFO] Arrow Vectors ...................................... SUCCESS [ 9.042 s] [INFO] Arrow Compression .................................. SUCCESS [ 2.722 s] [INFO] Arrow Tools ........................................ SUCCESS [ 3.561 s] [INFO] Arrow JDBC Adapter ................................. SUCCESS [ 5.981 s] [INFO] Arrow Plasma Client ................................ SUCCESS [ 2.069 s] [INFO] Arrow Flight ....................................... SUCCESS [ 1.839 s] [INFO] Arrow Flight Core .................................. FAILURE [ 20.163 s] [INFO] Arrow Flight GRPC .................................. SKIPPED [INFO] Arrow Flight SQL ................................... SKIPPED [INFO] Arrow Flight SQL JDBC Driver ....................... SKIPPED [INFO] Arrow Flight Integration Tests ..................... SKIPPED [INFO] Arrow AVRO Adapter ................................. SKIPPED [INFO] Arrow Algorithms ................................... SKIPPED [INFO] Arrow Performance Benchmarks ....................... SKIPPED ``` so it looks like I've not got some certificates that are required to test Flight Core? Authored-by: James Henderson <james@jarohen.dev> Signed-off-by: David Li <li.davidm96@gmail.com>
|
Issue resolved by pull request 35590 |
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
…esolves apache#35588 (apache#35590) resolves apache#35588 ### Are these changes tested? I've run `mvn test` locally, and got the following: ``` [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestTls.connectTls:43->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [ERROR] TestTls.connectTlsDisableServerVerification:93->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [ERROR] TestTls.rejectHostname:76->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [ERROR] TestTls.rejectInvalidCert:61->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [INFO] [ERROR] Tests run: 108, Failures: 0, Errors: 4, Skipped: 20 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache Arrow Java Root POM 11.0.0: [INFO] [INFO] Apache Arrow Java Root POM ......................... SUCCESS [ 6.392 s] [INFO] Arrow Format ....................................... SUCCESS [ 2.151 s] [INFO] Arrow Memory ....................................... SUCCESS [ 2.000 s] [INFO] Arrow Memory - Core ................................ SUCCESS [ 3.617 s] [INFO] Arrow Memory - Unsafe .............................. SUCCESS [ 2.478 s] [INFO] Arrow Memory - Netty ............................... SUCCESS [ 3.567 s] [INFO] Arrow Vectors ...................................... SUCCESS [ 9.042 s] [INFO] Arrow Compression .................................. SUCCESS [ 2.722 s] [INFO] Arrow Tools ........................................ SUCCESS [ 3.561 s] [INFO] Arrow JDBC Adapter ................................. SUCCESS [ 5.981 s] [INFO] Arrow Plasma Client ................................ SUCCESS [ 2.069 s] [INFO] Arrow Flight ....................................... SUCCESS [ 1.839 s] [INFO] Arrow Flight Core .................................. FAILURE [ 20.163 s] [INFO] Arrow Flight GRPC .................................. SKIPPED [INFO] Arrow Flight SQL ................................... SKIPPED [INFO] Arrow Flight SQL JDBC Driver ....................... SKIPPED [INFO] Arrow Flight Integration Tests ..................... SKIPPED [INFO] Arrow AVRO Adapter ................................. SKIPPED [INFO] Arrow Algorithms ................................... SKIPPED [INFO] Arrow Performance Benchmarks ....................... SKIPPED ``` so it looks like I've not got some certificates that are required to test Flight Core? Authored-by: James Henderson <james@jarohen.dev> Signed-off-by: David Li <li.davidm96@gmail.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
…esolves apache#35588 (apache#35590) resolves apache#35588 ### Are these changes tested? I've run `mvn test` locally, and got the following: ``` [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestTls.connectTls:43->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [ERROR] TestTls.connectTlsDisableServerVerification:93->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [ERROR] TestTls.rejectHostname:76->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [ERROR] TestTls.rejectInvalidCert:61->test:111->lambda$test$6:118 Runtime java.io.FileNotFoundException: /home/james/src/juxt/arrow/java/flight/flight-core/../../../testing/data/flight/cert0.pem (No such file or directory) [INFO] [ERROR] Tests run: 108, Failures: 0, Errors: 4, Skipped: 20 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache Arrow Java Root POM 11.0.0: [INFO] [INFO] Apache Arrow Java Root POM ......................... SUCCESS [ 6.392 s] [INFO] Arrow Format ....................................... SUCCESS [ 2.151 s] [INFO] Arrow Memory ....................................... SUCCESS [ 2.000 s] [INFO] Arrow Memory - Core ................................ SUCCESS [ 3.617 s] [INFO] Arrow Memory - Unsafe .............................. SUCCESS [ 2.478 s] [INFO] Arrow Memory - Netty ............................... SUCCESS [ 3.567 s] [INFO] Arrow Vectors ...................................... SUCCESS [ 9.042 s] [INFO] Arrow Compression .................................. SUCCESS [ 2.722 s] [INFO] Arrow Tools ........................................ SUCCESS [ 3.561 s] [INFO] Arrow JDBC Adapter ................................. SUCCESS [ 5.981 s] [INFO] Arrow Plasma Client ................................ SUCCESS [ 2.069 s] [INFO] Arrow Flight ....................................... SUCCESS [ 1.839 s] [INFO] Arrow Flight Core .................................. FAILURE [ 20.163 s] [INFO] Arrow Flight GRPC .................................. SKIPPED [INFO] Arrow Flight SQL ................................... SKIPPED [INFO] Arrow Flight SQL JDBC Driver ....................... SKIPPED [INFO] Arrow Flight Integration Tests ..................... SKIPPED [INFO] Arrow AVRO Adapter ................................. SKIPPED [INFO] Arrow Algorithms ................................... SKIPPED [INFO] Arrow Performance Benchmarks ....................... SKIPPED ``` so it looks like I've not got some certificates that are required to test Flight Core? Authored-by: James Henderson <james@jarohen.dev> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
It's currently implemented as
31 * valueCount, which returns a different hashCode for null values from different-lengthNullVectors. Presumably this should be a constant value?James
Component(s)
Java
The text was updated successfully, but these errors were encountered: