Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Support simple Substrait aggregate extensions #35607

Closed
rtpsw opened this issue May 16, 2023 · 0 comments · Fixed by #35608
Closed

[C++] Support simple Substrait aggregate extensions #35607

rtpsw opened this issue May 16, 2023 · 0 comments · Fixed by #35608
Assignees
@rtpsw
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@rtpsw
Copy link
Contributor

rtpsw commented May 16, 2023

Describe the enhancement requested

Currently, there is simple Substrait extension (ones under the urn:arrow:substrait_simple_extension_function URI) support only for functions. This issue will add support for aggregates as well.

Component(s)

C++
rtpsw added a commit to rtpsw/arrow that referenced this issue May 16, 2023
@rtpsw
apacheGH-35607: [C++] Support simple Substrait aggregate extensions
18f0194
@rtpsw rtpsw mentioned this issue May 16, 2023
Merged
icexelloss pushed a commit that referenced this issue May 17, 2023
@rtpsw
GH-35607: [C++] Support simple Substrait aggregate extensions (#35608)
6f0b348 
### Rationale for this change

See #35607.

### What changes are included in this PR?

A simple `SubstraitAggregateToArrow` converter for `urn:arrow:substrait_simple_extension_function` is added.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #35607

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
@icexelloss icexelloss added this to the 13.0.0 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtpsw rtpsw

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35607: [C++] Support simple Substrait aggregate extensions rtpsw/arrow
2 participants
@icexelloss @rtpsw