Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Update to double-conversion 3.3.0, activate new flags, remove patches #35669

Closed
3 tasks done
ianmcook opened this issue May 18, 2023 · 0 comments · Fixed by #36002
Closed
3 tasks done

[C++] Update to double-conversion 3.3.0, activate new flags, remove patches #35669

ianmcook opened this issue May 18, 2023 · 0 comments · Fixed by #36002
Assignees
@ianmcook
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@ianmcook
Copy link
Member

ianmcook commented May 18, 2023 •
edited
Loading

Describe the enhancement requested

double-conversion v3.3.0 adds a new feature that allows us to remove the special code that was added to our vendored copy of double-conversion in #9816.

  • Update vendored double-conversion to v3.3.0
  • Activate the flags EMIT_TRAILING_DECIMAL_POINT_IN_EXPONENTIAL and EMIT_TRAILING_ZERO_AFTER_POINT_IN_EXPONENTIAL.
  • Remove the patches in cpp/src/arrow/vendored/double-conversion/patches

Component(s)

C++
@ianmcook ianmcook mentioned this issue May 18, 2023
Merged
@ianmcook ianmcook self-assigned this Jun 8, 2023
@github-actions github-actions bot mentioned this issue Jun 8, 2023
Merged
@kou kou closed this as completed in #36002 Jun 9, 2023
kou pushed a commit that referenced this issue Jun 9, 2023
@ianmcook
GH-35669: [C++] Update to double-conversion 3.3.0, activate new flags…
0bbfe98 
…, remove patches (#36002)

[double-conversion v3.3.0](https://github.com/google/double-conversion/releases/tag/v3.3.0) adds a [new feature](google/double-conversion#195) that allows us to remove the special code that was added to our vendored copy of double-conversion in #9816.

This PR:
* Updates vendored double-conversion to v3.3.0
* Activates the new flags `EMIT_TRAILING_DECIMAL_POINT_IN_EXPONENTIAL` and `EMIT_TRAILING_ZERO_AFTER_POINT_IN_EXPONENTIAL`
* Removes the patches in `cpp/src/arrow/vendored/double-conversion/patches`

-----
* Closes: #35669

Authored-by: Ian Cook <ianmcook@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianmcook ianmcook

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35669: [C++] Update to double-conversion 3.3.0, activate new flags, remove patches ianmcook/arrow
2 participants
@kou @ianmcook