Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Support Batch Interface in BloomFilter #35729

Closed
mapleFU opened this issue May 24, 2023 · 0 comments · Fixed by #35731
Closed

[C++][Parquet] Support Batch Interface in BloomFilter #35729

mapleFU opened this issue May 24, 2023 · 0 comments · Fixed by #35731
Assignees
@mapleFU
Labels
Component: C++ Component: Parquet Type: enhancement
Milestone
13.0.0

Comments

@mapleFU
Copy link
Member

mapleFU commented May 24, 2023

Describe the enhancement requested

Parquet Hash and FindHash can support Batch Execution to avoid virtual function costs.

Component(s)

C++, Parquet
@github-actions github-actions bot mentioned this issue May 24, 2023
Merged
pitrou added a commit that referenced this issue May 30, 2023
@mapleFU @pitrou @wgtmac
GH-35729: [C++][Parquet] Implement batch interface for BloomFilter in…
2695293 
… Parquet (#35731)

### Rationale for this change

For optimizing #35691 . We need batch execution for BloomFilter

### What changes are included in this PR?

* Add `InsertHashes` and `Hashes` for BloomFilter
* Make `BloomFilter::Find` faster by inlining the bitmask computation inside the loop

* Closes: #35729

Lead-authored-by: mwish <maplewish117@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Co-authored-by: mwish <1506118561@qq.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 13.0.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Component: C++ Component: Parquet Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35729: [C++][Parquet] Implement batch interface for BloomFilter in Parquet mapleFU/arrow
2 participants
@pitrou @mapleFU