Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][GLib][Ruby] Pass GITHUB_ACTIONS environment variable to Docker containers #35752

Closed
kou opened this issue May 25, 2023 · 0 comments · Fixed by #35753
Closed

[CI][GLib][Ruby] Pass GITHUB_ACTIONS environment variable to Docker containers #35752

kou opened this issue May 25, 2023 · 0 comments · Fixed by #35753
Assignees
@kou
Labels
Component: Continuous Integration Component: GLib Component: Ruby Type: enhancement
Milestone
13.0.0

Comments

@kou
Copy link
Member

kou commented May 25, 2023

Describe the enhancement requested

GLib and Ruby parts use test-unit gem as a testing framework.
It checks GITHUB_ACTIONS=true environment variable whether tests are ran on GitHub Actions. If tests are ran on GitHub Actions, test-unit gem uses the output format that suitable for GitHub Actions.

Component(s)

Continuous Integration, GLib, Ruby
kou added a commit to kou/arrow that referenced this issue May 25, 2023
@kou
apacheGH-35752: [CI][GLib][Ruby] Pass GITHUB_ACTIONS environment vari…
ed1039e 
…able to Docker containers
@github-actions github-actions bot mentioned this issue May 25, 2023
Merged
kou added a commit to kou/arrow that referenced this issue May 25, 2023
@kou
apacheGH-35752: [CI][GLib][Ruby] Pass GITHUB_ACTIONS environment vari…
3ea9fc3 
…able to Docker containers
assignUser pushed a commit that referenced this issue May 25, 2023
@kou
GH-35752: [CI][GLib][Ruby] Pass GITHUB_ACTIONS environment variable t…
0cf7e39 
…o Docker containers (#35753)

### Rationale for this change

It's for choosing GitHub Actions suitable output automatically.

test-unit gem checks `GITHUB_ACTIONS=true` and the environment variable is set by GitHub Actions automatically.

### What changes are included in this PR?

Add `GITHUB_ACTIONS:` to `environment:`.

`c_glib/README.md` is updated to run CI jobs.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #35752

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 13.0.0 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Continuous Integration Component: GLib Component: Ruby Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35752: [CI][GLib][Ruby] Pass GITHUB_ACTIONS environment variable to Docker containers kou/arrow
2 participants
@kou @assignUser