Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] TypeEqual doesn't compare nullability in some cases #35763

Closed
hermanschaaf opened this issue May 25, 2023 · 0 comments · Fixed by #35764
Closed

[Go] TypeEqual doesn't compare nullability in some cases #35763

hermanschaaf opened this issue May 25, 2023 · 0 comments · Fixed by #35764
Assignees
@hermanschaaf
Labels
Component: Go Type: bug
Milestone
13.0.0

Comments

@hermanschaaf
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Due to a bug in the code, when checking type equivalence for two lists and also checking metadata, TypeEqual returns true when nullability differs between the lists.

Component(s)

Go
@github-actions github-actions bot mentioned this issue May 25, 2023
Merged
@zeroshade zeroshade added this to the 13.0.0 milestone May 25, 2023
zeroshade pushed a commit that referenced this issue May 25, 2023
@hermanschaaf
GH-35763: [Go] Fix TypeEqual for lists (#35764)
bd63ff4 
This fixes an edge case for list comparisons where TypeEqual would return true even when the nullability of the lists differed.
* Closes: #35763

Authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hermanschaaf hermanschaaf

Labels
Component: Go Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35763: [Go] Fix TypeEqual for lists cloudquery/arrow
2 participants
@zeroshade @hermanschaaf