Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift] Update reader/writer to user Result type, RecordBatch to accept single array only, and other minor fixes #35788

Closed
abandy opened this issue May 26, 2023 · 0 comments · Fixed by #35774
Closed

[Swift] Update reader/writer to user Result type, RecordBatch to accept single array only, and other minor fixes #35788

abandy opened this issue May 26, 2023 · 0 comments · Fixed by #35774
Assignees
@abandy
Labels
Component: Swift Type: enhancement
Milestone
13.0.0

Comments

@abandy
Copy link
Contributor

abandy commented May 26, 2023

Describe the enhancement requested

Changes:

  • Changed Reader and Writer to use Result<T, Error> instead of throwing. Since the Error is an enum the handling of the error is enforced.
  • Update RecordBatch to accept only a single array per column instead of chunked arrays (which could cause problems when writing out)
  • Added ability for Table to be created from RecordBatches
  • Fixed a bug with indexing in Chunked array with many arrays
  • Added tests for the above changes.
  • Switched ValidationErrors to ArrowError and added additional ArrowError values.
  • Add @discardableResult to certain methods so results can be ignored without warnings

Component(s)

Swift
@github-actions github-actions bot mentioned this issue May 26, 2023
Merged
@raulcd raulcd changed the title Update reader/writer to user Result type, RecordBatch to accept single array only, and other minor fixes [Swift] Update reader/writer to user Result type, RecordBatch to accept single array only, and other minor fixes May 27, 2023
kou pushed a commit that referenced this issue May 28, 2023
@abandy
GH-35788: [Swift] bug fixes and change reader/writer to user Result t…
d14b42a 
…ype (#35774)

Changes:
- Changed Reader and Writer to use Result<T, Error> instead of throwing.  Since the Error is an enum the handling of the error is enforced.
- Update RecordBatch to accept only a single array per column instead of chunked arrays (which could cause problems when writing out)
- Added ability for Table to be created from RecordBatches
- Fixed a bug with indexing in Chunked array with many arrays 
- Added tests for the above changes.
- Switched ValidationErrors to ArrowError and added additional ArrowError values.

* Closes: #35788

Authored-by: Alva Bandy <abandy@live.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abandy abandy

Labels
Component: Swift Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35788: [Swift] bug fixes and change reader/writer to user Result type abandy/arrow
2 participants
@kou @abandy