[C++] arrow fails to recognize installed abseil: The following configuration files were considered but not accepted: 20230125

[barracuda156]

Describe the bug, including details regarding any error messages, version, and platform.

macOS 13:

2023-05-31T03:56:27.5654270Z CMake Warning at cmake_modules/ThirdpartyToolchain.cmake:2828 (find_package):
2023-05-31T03:56:27.5654940Z   Could not find a configuration file for package "absl" that is compatible
2023-05-31T03:56:27.5655620Z   with requested version "20211102".
2023-05-31T03:56:27.5655840Z 
2023-05-31T03:56:27.5656030Z   The following configuration files were considered but not accepted:
2023-05-31T03:56:27.5656260Z 
2023-05-31T03:56:27.5656420Z     /opt/local/lib/cmake/absl/abslConfig.cmake, version: 20230125
2023-05-31T03:56:27.5656620Z 
2023-05-31T03:56:27.5656730Z Call Stack (most recent call first):
2023-05-31T03:56:27.5657040Z   cmake_modules/ThirdpartyToolchain.cmake:4198 (ensure_absl)
2023-05-31T03:56:27.5657430Z   cmake_modules/ThirdpartyToolchain.cmake:174 (build_google_cloud_cpp_storage)
2023-05-31T03:56:27.5657820Z   cmake_modules/ThirdpartyToolchain.cmake:280 (build_dependency)
2023-05-31T03:56:27.5658310Z   cmake_modules/ThirdpartyToolchain.cmake:4376 (resolve_dependency)
2023-05-31T03:56:27.5658630Z   CMakeLists.txt:506 (include)
2023-05-31T03:56:27.5658780Z 
2023-05-31T03:56:27.5658780Z 
2023-05-31T03:56:27.5779150Z CMake Warning at cmake_modules/ThirdpartyToolchain.cmake:2828 (find_package):
2023-05-31T03:56:27.5780320Z   Could not find a configuration file for package "absl" that is compatible
2023-05-31T03:56:27.5780820Z   with requested version "20220623".
2023-05-31T03:56:27.5781180Z 
2023-05-31T03:56:27.5782300Z   The following configuration files were considered but not accepted:
2023-05-31T03:56:27.5782560Z 
2023-05-31T03:56:27.5782730Z     /opt/local/lib/cmake/absl/abslConfig.cmake, version: 20230125
2023-05-31T03:56:27.5782930Z 
2023-05-31T03:56:27.5783400Z Call Stack (most recent call first):
2023-05-31T03:56:27.5783710Z   cmake_modules/ThirdpartyToolchain.cmake:4198 (ensure_absl)
2023-05-31T03:56:27.5784140Z   cmake_modules/ThirdpartyToolchain.cmake:174 (build_google_cloud_cpp_storage)
2023-05-31T03:56:27.5784560Z   cmake_modules/ThirdpartyToolchain.cmake:280 (build_dependency)
2023-05-31T03:56:27.5785020Z   cmake_modules/ThirdpartyToolchain.cmake:4376 (resolve_dependency)
2023-05-31T03:56:27.5785380Z   CMakeLists.txt:506 (include)
2023-05-31T03:56:27.5785540Z 
2023-05-31T03:56:27.5785550Z 
2023-05-31T03:56:27.5785890Z -- Building Abseil-cpp from source

This eventually leaves the build broken, as it tries, apparently, to overwrite existing abseil files.

Why it fails to recognize our abseil? Portfiles here:

https://github.com/macports/macports-ports/blob/master/devel/apache-arrow/Portfile
https://github.com/macports/macports-ports/blob/master/devel/abseil/Portfile

Component(s)

C++

[kou]

Could you try this patch?

diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index a764acb6c..d0398d2d0 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -2823,7 +2823,7 @@ macro(ensure_absl)
       # 20211102 or later. We need to update
       # ARROW_ABSL_REQUIRED_LTS_VERSIONS list when new Abseil LTS is
       # released.
-      set(ARROW_ABSL_REQUIRED_LTS_VERSIONS 20211102 20220623)
+      set(ARROW_ABSL_REQUIRED_LTS_VERSIONS 20230125 20220623 20211102)
       foreach(_VERSION ${ARROW_ABSL_REQUIRED_LTS_VERSIONS})
         find_package(absl ${_VERSION})
         if(absl_FOUND)

[barracuda156]

@kou I will test this today, thank you.

[barracuda156]

@kou Yes, this seems to work, thank you!

P. S. We have some Python dependencies for py-arrow failing now with new Abseil. Troublesome update they made :)

[kou]

Thanks for testing the patch!

We'll merge the patch soon.