Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift] Update stored type info to use ArrowType from ArrowType.info. Add binary, time32, and time64 #35969

Closed
abandy opened this issue Jun 7, 2023 · 0 comments · Fixed by #35985
Closed

[Swift] Update stored type info to use ArrowType from ArrowType.info. Add binary, time32, and time64 #35969

abandy opened this issue Jun 7, 2023 · 0 comments · Fixed by #35985
Assignees
@abandy
Labels
Component: Swift Type: enhancement
Milestone
13.0.0

Comments

@abandy
Copy link
Contributor

abandy commented Jun 7, 2023

Describe the enhancement requested

  • Update swift classes to use the ArrowType instead of the ArrowType.info enum to store the type information. This was required due to the time32 and time64 classes requiring to carry more information than just the type (seconds, microseconds, etc..)
  • Additional types added are binary, time32, time64 and decimal 128 (uses built in swift decimal type).

Component(s)

Swift
@abandy abandy changed the title [Swift] Update stored type info to use ArrowType from ArrowType.info. Add binary, time32, time64, and decimal [Swift] Update stored type info to use ArrowType from ArrowType.info. Add binary, time32, and time64 Jun 7, 2023
abandy added a commit to abandy/arrow that referenced this issue Jun 7, 2023
@abandy
apacheGH-35969: [Swift] use ArrowType instead of ArrowType.info and a…
fe78afc 
…dd binary, time32, and time64
@github-actions github-actions bot mentioned this issue Jun 7, 2023
Merged
kou added a commit that referenced this issue Jun 23, 2023
@abandy @kou
GH-35969: [Swift] use ArrowType instead of ArrowType.info and add bin…
4cbab52 
…ary, time32 and time64 types (#35985)

Changes:
- Updated code to use ArrowType instead of ArrowType.info to store the arrow type in classes and structs.  This was done due to Time32 and Time64 requiring additional information beyond just the basic enum info.
- Add binary, time32 and time64 types.
* Closes: #35969

Lead-authored-by: Alva Bandy <abandy@live.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abandy abandy

Labels
Component: Swift Type: enhancement
Projects
None yet
Milestone
13.0.0
2 participants
@kou @abandy