Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] go1.18 builds broken with deprecated message #35982

Closed
zeroshade opened this issue Jun 7, 2023 · 0 comments · Fixed by #35983
Closed

[Go] go1.18 builds broken with deprecated message #35982

zeroshade opened this issue Jun 7, 2023 · 0 comments · Fixed by #35983
Assignees
@zeroshade
Labels
Component: Go Type: bug
Milestone
13.0.0

Comments

@zeroshade
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

#35654 was merged without manually rebasing first so it didn't catch the change that deprecated usage of a few functions in it until after the merge and builds. Usage of (*MapType).ValueType() was deprecated which is causing the linting step to break all go1.18 builds (since we only build the compute on go1.18+)

Component(s)

Go
zeroshade added a commit to zeroshade/arrow that referenced this issue Jun 7, 2023
@zeroshade
apacheGH-35982: [Go] Fix go1.18 broken builds
47dc416
@github-actions github-actions bot mentioned this issue Jun 7, 2023
Merged
zeroshade added a commit that referenced this issue Jun 7, 2023
@zeroshade
GH-35982: [Go] Fix go1.18 broken builds (#35983)
08caf00 
### Rationale for this change
Fix usage of deprecated functions to fix the Go 1.18 builds.

* Closes: #35982

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Go Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-35982: [Go] Fix go1.18 broken builds zeroshade/arrow
1 participant
@zeroshade