Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Handle duplicate field names in structs #36014

Closed
lidavidm opened this issue Jun 9, 2023 · 0 comments · Fixed by #36015
Closed

[Go] Handle duplicate field names in structs #36014

lidavidm opened this issue Jun 9, 2023 · 0 comments · Fixed by #36015
Assignees
@lidavidm
Labels
Component: Go Type: enhancement
Milestone
13.0.0

Comments

@lidavidm
Copy link
Member

lidavidm commented Jun 9, 2023

Describe the enhancement requested

This affects the C Data Interface since all schemas are encoded as structs

Component(s)

Go
@lidavidm lidavidm self-assigned this Jun 9, 2023
lidavidm added a commit to lidavidm/arrow that referenced this issue Jun 9, 2023
@lidavidm
apacheGH-36014: [Go] Allow duplicate field names in structs
a0ae203
@github-actions github-actions bot mentioned this issue Jun 9, 2023
Merged
lidavidm added a commit to lidavidm/arrow that referenced this issue Jun 9, 2023
@lidavidm
apacheGH-36014: [Go] Allow duplicate field names in structs
99c3a25
@lidavidm lidavidm added this to the 13.0.0 milestone Jun 12, 2023
lidavidm added a commit that referenced this issue Jun 12, 2023
@lidavidm
GH-36014: [Go] Allow duplicate field names in structs (#36015)
b642707 
### Rationale for this change

The package segfaulted before.

### What changes are included in this PR?

Allow duplicate field names (in general methods will return the first field if there are duplicates)

### Are these changes tested?

Yes

### Are there any user-facing changes?

Yes

* Closes: #36014

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36014: [Go] Allow duplicate field names in structs lidavidm/arrow
1 participant
@lidavidm