Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][Flight] Add Flight Client Cookie Middleware #36070

Closed
zeroshade opened this issue Jun 14, 2023 · 0 comments · Fixed by #36071
Closed

[Go][Flight] Add Flight Client Cookie Middleware #36070

zeroshade opened this issue Jun 14, 2023 · 0 comments · Fixed by #36071
Assignees
@zeroshade
Labels
Component: FlightRPC Component: Go Type: enhancement
Milestone
13.0.0

Comments

@zeroshade
Copy link
Member

Describe the enhancement requested

There are some clients that expect to send and work with Cookies across http2 headers via gRPC using Arrow Flight, particularly with Flight SQL as mentioned here.

So let's add a flight cookie middleware that is easy to leverage and use.

Component(s)

FlightRPC, Go
@zeroshade zeroshade self-assigned this Jun 14, 2023
zeroshade added a commit to zeroshade/arrow that referenced this issue Jun 14, 2023
@zeroshade
apacheGH-36070: [Go][Flight] Add Flight Client Cookie Middleware
d74361e
@github-actions github-actions bot mentioned this issue Jun 14, 2023
Merged
zeroshade added a commit that referenced this issue Jun 14, 2023
@zeroshade
GH-36070: [Go][Flight] Add Flight Client Cookie Middleware (#36071)
b4ac585 
### Rationale for this change
See apache/arrow-adbc#716

### What changes are included in this PR?
`NewClientCookieMiddleware` function is added to the Flight package which returns a `ClientMiddleware` which can be used with flight and flightsql clients.

### Are these changes tested?
Yes.

### Are there any user-facing changes?
No.

* Closes: #36070

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: FlightRPC Component: Go Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36070: [Go][Flight] Add Flight Client Cookie Middleware zeroshade/arrow
1 participant
@zeroshade