Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Not obvious that ConcatenateTablesOptions::field_merge_options only apply when unify_schemas = True #36074

Closed
westonpace opened this issue Jun 14, 2023 · 0 comments · Fixed by #36075
Closed

[C++] Not obvious that ConcatenateTablesOptions::field_merge_options only apply when unify_schemas = True #36074

westonpace opened this issue Jun 14, 2023 · 0 comments · Fixed by #36075
Assignees
@westonpace
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@westonpace
Copy link
Member

Describe the enhancement requested

I was trying to concatenate two batches with mixed nullability on the schema fields. I expected setting field_merge_options.promote_nullability = true would be sufficient and didn't realize I also need to set unify_schemas = true. So I just want to clarify the docs a bit.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Jun 14, 2023
Merged
@westonpace westonpace added this to the 13.0.0 milestone Jun 23, 2023
westonpace added a commit that referenced this issue Jun 23, 2023
@westonpace
GH-36074: [C++] Clarify docs for ConcatenateTablesOptions::field_merg…
10708b3 
…e_options (#36075)

### Rationale for this change

There was no docstring for this field before

### What changes are included in this PR?

I added a docstring for the field

### Are these changes tested?

No, it's just a comment

### Are there any user-facing changes?

No
* Closes: #36074

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonpace westonpace

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36074: [C++] Clarify docs for ConcatenateTablesOptions::field_merge_options westonpace/arrow
1 participant
@westonpace