Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] deperacted gbenchmark cli flag causes error #36076

Closed
assignUser opened this issue Jun 14, 2023 · 0 comments · Fixed by #36077
Closed

[C++] deperacted gbenchmark cli flag causes error #36076

assignUser opened this issue Jun 14, 2023 · 0 comments · Fixed by #36077
Assignees
@assignUser
Labels
Component: C++ Type: bug
Milestone
13.0.0

Comments

@assignUser
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

Google benchmark removed the long deprecated color_print cli flag in 1.6.1. This will cause the benchmarks to error when run if benchmark version >=1.6.1 is used. We bundle 1.7.1 since 12.0.0.

We set this flag unconditionally to false (for historic reasons I assume as this change is from 2017) here. I think we should not set the flag at all which will default to detecting if the env supports tty colors. If this causes cli issue we should set the correct flag and make it configurable.

Component(s)

C++
@github-actions github-actions bot mentioned this issue Jun 14, 2023
Merged
assignUser added a commit that referenced this issue Jun 15, 2023
@assignUser
GH-36076: [C++] Remove deprecated cli flag (#36077)
1fb415c 
### Rationale for this change
The deprecated flag causes errors on benchmark >= 1.6.1.

### Are there any user-facing changes?

No, benchmark defaults to an auto option to determine if colors are supported or not.
* Closes: #36076

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 13.0.0 milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36076: [C++] Remove deprecated cli flag assignUser/arrow
1 participant
@assignUser