Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Consolidate common python functionality between Table and RecordBatch classes #36129

Closed
danepitkin opened this issue Jun 16, 2023 · 0 comments · Fixed by #36130
Closed

[Python] Consolidate common python functionality between Table and RecordBatch classes #36129

danepitkin opened this issue Jun 16, 2023 · 0 comments · Fixed by #36130
Assignees
@danepitkin
Labels
Component: Python Type: enhancement
Milestone
13.0.0

Comments

@danepitkin
Copy link
Member

Describe the enhancement requested

This will reduce duplication of code in table.pxi. There is a common parent class _Tabular that can house these methods.

Component(s)

Python
danepitkin added a commit to danepitkin/arrow that referenced this issue Jun 16, 2023
@danepitkin
apacheGH-36129: Consolidate common python functionality between Table…
3046367 
… and RecordBatch classes
@github-actions github-actions bot mentioned this issue Jun 16, 2023
Merged
jorisvandenbossche pushed a commit that referenced this issue Jun 28, 2023
@danepitkin
GH-36129: [Python] Consolidate common APIs in Table and RecordBatch (#…
427f550 
…36130)

### Rationale for this change

Deduplicate python code in subclasses. The following functions are moved to the shared parent class:
```
__init__
__len__
column_names
from_pylist
from_pydict
itercolumns
to_pylist
to_pydict
```
### What changes are included in this PR?

Refactoring and minor test updates.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* Closes: #36129

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 13.0.0 milestone Jun 28, 2023
@AlenkaF AlenkaF mentioned this issue Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danepitkin danepitkin

Labels
Component: Python Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36129: [Python] Consolidate common APIs in Table and RecordBatch danepitkin/arrow
2 participants
@jorisvandenbossche @danepitkin