Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Dev] Use python3 to run IWYU #36157

Closed
kou opened this issue Jun 19, 2023 · 0 comments · Fixed by #36159
Closed

[C++][Dev] Use python3 to run IWYU #36157

kou opened this issue Jun 19, 2023 · 0 comments · Fixed by #36159
Assignees
@kou
Labels
Component: C++ Component: Developer Tools Type: enhancement
Milestone
13.0.0

Comments

@kou
Copy link
Member

kou commented Jun 19, 2023

Describe the enhancement requested

cpp/build-support/iwyu/iwyu.sh uses python but python3 may be used for Python 3.

Component(s)

C++, Developer Tools
@kou kou mentioned this issue Jun 19, 2023
Merged
kou added a commit that referenced this issue Jun 21, 2023
@kou
GH-36157: [C++][Dev] Add support for using python3 to run IWYU (#36159)
35fd769 
### Rationale for this change

Python executable name is hard-corded in `cpp/build-support/iwyu/iwyu.sh`. If a developer uses `python3` for Python executable, the developer can't use the script.

### What changes are included in this PR?

Add support for customizing Python executable name (and path) by `PYTHON` environment variable like other scripts.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #36157

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 13.0.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Developer Tools Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36157: [C++][Dev] Add support for using python3 to run IWYU kou/arrow
1 participant
@kou