Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Upgrade Netty due to CVE #36209

Closed
BryanCutler opened this issue Jun 21, 2023 · 2 comments · Fixed by #36211
Closed

[Java] Upgrade Netty due to CVE #36209

BryanCutler opened this issue Jun 21, 2023 · 2 comments · Fixed by #36211
Assignees
Labels
Component: Java Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: bug
Milestone

Comments

@BryanCutler
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

CVE GHSA-6mjq-h674-j845 fixed in Netty 4.1.94.Final

I don't think this relates to Arrow usage with Netty, but there is an API change that Arrow is not compatible with and needs a patch.

Component(s)

Java

@BryanCutler BryanCutler self-assigned this Jun 21, 2023
@BryanCutler BryanCutler added the Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. label Jun 21, 2023
lidavidm pushed a commit that referenced this issue Jun 21, 2023
### Rationale for this change

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

### What changes are included in this PR?

Upgrading Netty, gRPC and Protobuf dependencies

### Are these changes tested?
Existing tests

### Are there any user-facing changes?
No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.
 
GHSA-6mjq-h674-j845

* Closes: #36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 13.0.0 milestone Jun 21, 2023
lriggs pushed a commit to lriggs/arrow that referenced this issue Jun 28, 2023
…pache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
lriggs added a commit to dremio/arrow that referenced this issue Jun 28, 2023
…pache#36211) (#27)

* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
lriggs added a commit to dremio/arrow that referenced this issue Jun 28, 2023
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
@zhfeng
Copy link

zhfeng commented Jun 30, 2023

Hi @lidavidm @BryanCutler , is there any plan to backport this fix to 10.0.x?

@lidavidm
Copy link
Member

@zhfeng not at the moment. You can discuss on dev@arrow.apache.org (https://arrow.apache.org/community/) but so far I don't think we will even backport to 12.0.x.

lriggs added a commit to dremio/arrow that referenced this issue Jul 13, 2023
…pache#36211) (#27)

* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
lriggs added a commit to dremio/arrow that referenced this issue Jul 13, 2023
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
lriggs added a commit to dremio/arrow that referenced this issue Jul 21, 2023
…pache#36211) (#27)

* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
lriggs added a commit to dremio/arrow that referenced this issue Jul 21, 2023
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
lriggs added a commit to dremio/arrow that referenced this issue Jul 28, 2023
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
lriggs added a commit to dremio/arrow that referenced this issue Jul 28, 2023
…pache#36211) (#27)

* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
xxlaykxx pushed a commit to dremio/arrow that referenced this issue Oct 29, 2023
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this issue Dec 19, 2023
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this issue Dec 19, 2023
…pache#36211) (#27)

* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this issue Jan 16, 2024
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
DenisTarasyuk pushed a commit to dremio/arrow that referenced this issue Mar 6, 2024
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
lriggs added a commit to lriggs/arrow that referenced this issue Mar 12, 2024
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
lriggs added a commit to lriggs/arrow that referenced this issue Apr 25, 2024
* apacheGH-36209: [Java] Upgrade Netty due to security vulnerability (apache#36211)

Upgrading Netty dependency due to CVE GHSA-6mjq-h674-j845
This also requires a patch to arrow-memory

Upgrading Netty, gRPC and Protobuf dependencies

Existing tests

No

**This PR contains a "Critical Fix".**

netty-handler SniHandler 16MB allocation

The SniHandler can allocate up to 16MB of heap for each channel during the TLS handshake. When the handler or the channel does not have an idle timeout, it can be used to make a TCP server using the SniHandler to allocate 16MB of heap.

GHSA-6mjq-h674-j845

* Closes: apache#36209

Authored-by: Bryan Cutler <cutlerb@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>

* Restore jackson version.

* Use local based ccache for Mac build instead of sscache.

---------

Signed-off-by: David Li <li.davidm96@gmail.com>
Co-authored-by: Bryan Cutler <cutlerb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Java Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants