Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add benchmarks for "if_else" kernel on lists #36255

Closed
felipecrv opened this issue Jun 22, 2023 · 0 comments · Fixed by #36256
Closed

[C++] Add benchmarks for "if_else" kernel on lists #36255

felipecrv opened this issue Jun 22, 2023 · 0 comments · Fixed by #36256
Assignees
@felipecrv
Labels
Component: Benchmarking Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

"if_else" kernels kernels with list input can have their perf improved at the cost of code specialization. I'm working on this problem and would like to introduce benchmarks that measure how it behaves currently.

Component(s)

C++
@felipecrv felipecrv self-assigned this Jun 22, 2023
@github-actions github-actions bot mentioned this issue Jun 22, 2023
Merged
@pitrou pitrou added this to the 13.0.0 milestone Jun 27, 2023
pitrou pushed a commit that referenced this issue Jun 27, 2023
@felipecrv
GH-36255: [C++] Add benchmarks for "if_else" kernel on lists (#36256)
2e36cf5 
### Rationale for this change

"if_else" kernels kernels with list input can have their perf improved at the cost of code specialization. I'm working on this problem and would like to introduce benchmarks that measure how it behaves currently.

### What changes are included in this PR?

Only the new benchmarks and addition of `items_per_second` metric on the others.

### Are these changes tested?

By running the benchmarks.

### Are there any user-facing changes?

No.
* Closes: #36255

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: Benchmarking Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36255: [C++] Add benchmarks for "if_else" kernel on lists felipecrv/arrow
2 participants
@felipecrv @pitrou