-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36264: [R] Add scalar() function #36265
Conversation
I feel like there may be a reason we haven't done this previously, though a cursory glance to see if it's an exported function from other packages (I just ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely worth having! Perhaps it didn't happen because we also have Expression$scalar()
which is what all the bindings use.
It's true that scalar()
is a tiny bit generic...the closest thing I found was rlang::is_scalar_xx()
and assertthat::is.scalar()
(which helpfully returns TRUE
for an arrow::Scalar
. I think it's fine! There's always arrow_scalar()
if you're worried.
Thanks for looking for those! If you're happy with this as-is, I'm happy too. Will merge once CI is green. |
|
Conbench analyzed the 6 benchmark runs on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Fixes #36264 36264