Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][Parquet] Improve the error messages in the row group writer #36319

Closed
wolfeidau opened this issue Jun 27, 2023 · 0 comments · Fixed by #36320
Closed

[Go][Parquet] Improve the error messages in the row group writer #36319

wolfeidau opened this issue Jun 27, 2023 · 0 comments · Fixed by #36320
Assignees
@wolfeidau
Labels
Component: Go Type: enhancement
Milestone
13.0.0

Comments

@wolfeidau
Copy link
Contributor

wolfeidau commented Jun 27, 2023 •
edited

Describe the enhancement requested

I am using the parquet writer and encountered some ambiguous error messages, when i dived into the code I found some helpful information which would we can add to these messages.

Message as follows

arrow/go/parquet/file/row_group_writer.go

Line 119 in f8ea9d5

return xerrors.New("row mismatch error")

It would be great to make this better for the next person.

Component(s)

Go
wolfeidau added a commit to wolfeidau/arrow that referenced this issue Jun 27, 2023
@wolfeidau
apacheGH-36319: [Go][Parquet] Improved row group writer error messages
9ee8e78
@github-actions github-actions bot mentioned this issue Jun 27, 2023
Merged
wolfeidau added a commit to wolfeidau/arrow that referenced this issue Jun 27, 2023
@wolfeidau
apacheGH-36319: [Go][Parquet] Improved row group writer error messages
5e60a12
zeroshade pushed a commit that referenced this issue Jul 5, 2023
@wolfeidau
GH-36319: [Go][Parquet] Improved row group writer error messages (#36320
ff6717b 
)

### Rationale for this change

### What changes are included in this PR?

Updated error messages for mismatched column row counts to help identify the column, or rowgroup index which failed the check, and how many rows were expected vs found.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.

* Closes: #36319

Authored-by: Mark Wolfe <mark@wolfe.id.au>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolfeidau wolfeidau

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36319: [Go][Parquet] Improved row group writer error messages wolfeidau/arrow
2 participants
@wolfeidau @zeroshade