Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][CI] Sporadic errors in arrow-acero-asof-join-node-test #36331

Closed
pitrou opened this issue Jun 27, 2023 · 5 comments · Fixed by #36356
Closed

[C++][CI] Sporadic errors in arrow-acero-asof-join-node-test #36331

pitrou opened this issue Jun 27, 2023 · 5 comments · Fixed by #36356
Assignees
@rtpsw
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
13.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jun 27, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Various errors seem to occur intermittently on CI.

One example:

[ RUN      ] AsofJoinTest.BackpressureWithBatchesGen
/arrow/cpp/src/arrow/acero/asof_join_node_test.cc:1516: Failure
Value of: has_bp_been_applied()
  Actual: false
Expected: true
[  FAILED  ] AsofJoinTest.BackpressureWithBatchesGen (10693 ms)

from https://github.com/apache/arrow/actions/runs/5391899018/jobs/9789453616?pr=36215#step:6:3333

Another example:
logs
from https://github.com/apache/arrow/actions/runs/5376323460/jobs/9753323965#step:10:338

Component(s)

C++, Continuous Integration
@pitrou
Copy link
Member Author

pitrou commented Jun 27, 2023

@rtpsw @icexelloss

@pitrou pitrou added this to the 13.0.0 milestone Jun 27, 2023
@icexelloss
Copy link
Contributor

Thanks @pitrou - I noticed this the other day as well: #36248

We can probably disable this test until we figure out how to make this more robust

@icexelloss
Copy link
Contributor

@rtpsw Can you please take a look

@kou kou mentioned this issue Jun 28, 2023
Merged
@pitrou pitrou mentioned this issue Jun 28, 2023
Merged
rtpsw added a commit to rtpsw/arrow that referenced this issue Jun 28, 2023
@rtpsw
apacheGH-36331: [C++][CI] Sporadic errors in `arrow-acero-asof-join-n…
dc35f55 
…ode-test`
kou pushed a commit that referenced this issue Jun 29, 2023
@rtpsw
GH-36331: [C++][CI] Sporadic errors in AsofJoinTest (#36356)
5cc6aa3 
### Rationale for this change

Skipping a flaky test until a robust way for it is found.

### What changes are included in this PR?

The `AsofJoinTest.BackpressureWithBatchesGen` test is skipped.

### Are these changes tested?

N/A

### Are there any user-facing changes?

No.

* Closes: #36331

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou
Copy link
Member

kou commented Jun 29, 2023

@rtpsw Could you add "take" only comment here to assign you to this issue?

@rtpsw
Copy link
Contributor

rtpsw commented Jun 29, 2023

take

@raulcd raulcd mentioned this issue Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtpsw rtpsw

Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36331: [C++][CI] Sporadic errors in AsofJoinTest rtpsw/arrow
4 participants
@kou @icexelloss @pitrou @rtpsw