[C++] Add arrow::ipc::Listener::OnSchemaDecoded(schema, filtered_schema) #36407
Comments
bkietz
pushed a commit
that referenced
this issue
Jul 7, 2023
…tered_schema) (#36533) ### Rationale for this change The current `arrow::ipc::Listener::OnSchemaDecoded()` receives only the original schema. But we have filtered schema in decode phase. Filtered schema is useful for some cases. So we should pass the filtered schema too. ### What changes are included in this PR? This adds `arrow::ipc::Listener::OnSchemaDecoded(schema, filtered_schema)`. The default implementation of it just calls `OnSchemaDecoded(schema)` to keep backward compatibility. This also adds `arrow::ipc::CollectListener::filtered_schema()`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #36407 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
The current
arrow::ipc::Listener::OnSchemaDecoded()receives only the original schema. But we have filtered schema in decode phase. Filtered schema is useful for some cases. So we should pass the filtered schema too.We may want to add
arrow::ipc::CollectListener::filtered_schema()to.See also the discussion at #36344 (comment) .
Component(s)
C++
The text was updated successfully, but these errors were encountered: