Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add missing type_traits.h predicate: is_var_length_list() #36414

Closed
felipecrv opened this issue Jun 30, 2023 · 0 comments · Fixed by #36415
Closed

[C++] Add missing type_traits.h predicate: is_var_length_list() #36414

felipecrv opened this issue Jun 30, 2023 · 0 comments · Fixed by #36415
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
13.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

The other predicates have a templated predicate and a constexpr function that takes a type id. is_var_length_list_type<> is missing its is_var_length_list() counterpart.

A table summarizing the predicates for all the list-related type predicates so far:

Predicate Map LargeList List FixedList
is_var_length_list_type X X X
is_list_type X X X
is_list_like_type X X X X
is_fixed_size_list_type X

Component(s)

C++
@felipecrv felipecrv self-assigned this Jun 30, 2023
@github-actions github-actions bot mentioned this issue Jun 30, 2023
Merged
@pitrou pitrou added this to the 13.0.0 milestone Jul 3, 2023
pitrou added a commit that referenced this issue Jul 3, 2023
@felipecrv @pitrou
GH-36414: [C++] Add missing type_traits.h predicate: is_var_length_li…
07d272b 
…st() (#36415)

### Rationale for this change

`is_var_length_list_type<T>` is missing its `is_var_length_list(type_id)` counterpart.

### What changes are included in this PR?

 - New function
 - Use of `is_var_length_list_type<T>` directly (instead of using deprecated `is_base_list_type<T>`

### Are these changes tested?

Yes.
* Closes: #36414

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
westonpace pushed a commit to westonpace/arrow that referenced this issue Jul 7, 2023
@felipecrv @pitrou @westonpace
apacheGH-36414: [C++] Add missing type_traits.h predicate: is_var_len…
e4662a6 
…gth_list() (apache#36415)

### Rationale for this change

`is_var_length_list_type<T>` is missing its `is_var_length_list(type_id)` counterpart.

### What changes are included in this PR?

 - New function
 - Use of `is_var_length_list_type<T>` directly (instead of using deprecated `is_base_list_type<T>`

### Are these changes tested?

Yes.
* Closes: apache#36414

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36414: [C++] Add missing type_traits.h predicate: is_var_length_list() felipecrv/arrow
2 participants
@felipecrv @pitrou