[C++] Add Buffer::data_as #36417
Comments
bkietz
added a commit
to bkietz/arrow
that referenced
this issue
Jun 30, 2023
bkietz
added a commit
to bkietz/arrow
that referenced
this issue
Jul 6, 2023
pitrou
pushed a commit
to bkietz/arrow
that referenced
this issue
Jul 12, 2023
pitrou
pushed a commit
that referenced
this issue
Jul 12, 2023
### Rationale for this change
There's a lot of boilerplate in casting buffer bytes. A templated accessor will decrease that.
### What changes are included in this PR?
- `{Buffer, BufferBuilder, BufferSpan}::{data_as<T>, mutable_data_as<T>}`
- rewriting a few files' worth of reinterpret_casts to use these accessors to showcase usage
- `Buffer::FromVector`, a std::vector analog to Buffer::FromString
- some tangential cleanup of unnecessary copies in the Array classes
### Are these changes tested?
Not really. The rewritten files exercise the new accessors
### Are there any user-facing changes?
No, but I've noticed `Buffer::operator[]` again and that should probably be deprecated.
* Closes: #36417
Authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
chelseajonesr
pushed a commit
to chelseajonesr/arrow
that referenced
this issue
Jul 20, 2023
…pache#36418) ### Rationale for this change There's a lot of boilerplate in casting buffer bytes. A templated accessor will decrease that. ### What changes are included in this PR? - `{Buffer, BufferBuilder, BufferSpan}::{data_as<T>, mutable_data_as<T>}` - rewriting a few files' worth of reinterpret_casts to use these accessors to showcase usage - `Buffer::FromVector`, a std::vector analog to Buffer::FromString - some tangential cleanup of unnecessary copies in the Array classes ### Are these changes tested? Not really. The rewritten files exercise the new accessors ### Are there any user-facing changes? No, but I've noticed `Buffer::operator[]` again and that should probably be deprecated. * Closes: apache#36417 Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this issue
Aug 20, 2023
…pache#36418) ### Rationale for this change There's a lot of boilerplate in casting buffer bytes. A templated accessor will decrease that. ### What changes are included in this PR? - `{Buffer, BufferBuilder, BufferSpan}::{data_as<T>, mutable_data_as<T>}` - rewriting a few files' worth of reinterpret_casts to use these accessors to showcase usage - `Buffer::FromVector`, a std::vector analog to Buffer::FromString - some tangential cleanup of unnecessary copies in the Array classes ### Are these changes tested? Not really. The rewritten files exercise the new accessors ### Are there any user-facing changes? No, but I've noticed `Buffer::operator[]` again and that should probably be deprecated. * Closes: apache#36417 Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Buffer's data is usually cast to a non-byte type before use, which requires a lot of boilerplate with
reinterpret_cast. If the buffer happens to live in anArrayDatawe can useGetValuesbut bare buffers don't have access to this. Let's add an accessor which does the same thing for bare buffers:const T* Buffer::data_as<T>() constandT* Buffer::mutable_data_as<T>()will greatly simplify usage of buffers.Component(s)
C++
The text was updated successfully, but these errors were encountered: