Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][C++] test-ubuntu-20.04-cpp-20 failure on AWS SDK #36452

Closed
pitrou opened this issue Jul 4, 2023 · 0 comments · Fixed by #36454
Closed

[CI][C++] test-ubuntu-20.04-cpp-20 failure on AWS SDK #36452

pitrou opened this issue Jul 4, 2023 · 0 comments · Fixed by #36454

Comments

@pitrou
Copy link
Member

pitrou commented Jul 4, 2023

Describe the bug, including details regarding any error messages, version, and platform.

See CI example:
https://github.com/ursacomputing/crossbow/actions/runs/5453237382/jobs/9921803828#step:6:1506

Excerpt:

-- Configuring incomplete, errors occurred!
See also "/build/cpp/awssdk_ep-prefix/src/awssdk_ep-build/CMakeFiles/CMakeOutput.log".
See also "/build/cpp/awssdk_ep-prefix/src/awssdk_ep-build/CMakeFiles/CMakeError.log".

-- stderr output is:
CMake Error at cmake/platform/linux.cmake:49 (message):
  Could not determine support for atomic operations.
Call Stack (most recent call first):
  CMakeLists.txt:173 (apply_post_project_platform_settings)



CMake Error at /build/cpp/awssdk_ep-prefix/src/awssdk_ep-stamp/awssdk_ep-configure-DEBUG.cmake:47 (message):
  Stopping after outputting logs.

Detailed CMake output from AWS SDK:

Performing C++ SOURCE FILE Test LIBATOMIC_EXISTS failed with the following output:
Change Dir: /build/cpp/awssdk_ep-prefix/src/awssdk_ep-build/CMakeFiles/CMakeTmp

Run Build Command(s):/usr/bin/ninja cmTC_0fd00 && [1/2] Building CXX object CMakeFiles/cmTC_0fd00.dir/src.cxx.o
FAILED: CMakeFiles/cmTC_0fd00.dir/src.cxx.o 
/usr/bin/c++    -fdiagnostics-color=always -fPIC -DLIBATOMIC_EXISTS -std=c++20 -o CMakeFiles/cmTC_0fd00.dir/src.cxx.o -c src.cxx
c++: error: unrecognized command line option '-std=c++20'; did you mean '-std=c++2a'?
ninja: build stopped: subcommand failed.


Source file was:

int main() {
    __atomic_load_8(nullptr, 0);
    return 0;
}

So it seems we're testing C++20 compatibility with a C++ compiler (/usr/bin/cc) that only has preliminary support for C++20 (it doesn't support -std=c++20).

Component(s)

C++, Continuous Integration

@pitrou pitrou self-assigned this Jul 4, 2023
pitrou added a commit to pitrou/arrow that referenced this issue Jul 4, 2023
We were testing C++20 compatibility on a gcc version that only accepts `-std=c++2a`, not `-std=c++20`.
Switch to a newer Ubuntu, and therefore gcc, version.
pitrou added a commit that referenced this issue Jul 4, 2023
We were testing C++20 compatibility on a gcc version that only accepts `-std=c++2a`, not `-std=c++20`. Switch to a newer Ubuntu, and therefore gcc, version.

* Closes: #36452

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 13.0.0 milestone Jul 4, 2023
westonpace pushed a commit to westonpace/arrow that referenced this issue Jul 7, 2023
…apache#36454)

We were testing C++20 compatibility on a gcc version that only accepts `-std=c++2a`, not `-std=c++20`. Switch to a newer Ubuntu, and therefore gcc, version.

* Closes: apache#36452

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant