New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][FlightRPC] Use gRPC version macros if possible #36479
Comments
cc @lidavidm |
Should we just drop support for older gRPC entirely? At this point 1.27 is from 3 years ago |
I have no idea. How hard is it to maintain support? @kou In any case, we have feature tests for many versions between 1.27 and 1.51 anyway. |
Sure, but using the version macros doesn't really help us there. |
Except if we add another feature test for the presence of the version macros :-) |
We can require gRPC 1.30 or later (drop support for 1.27) because:
Ubuntu versions: https://packages.ubuntu.com/search?keywords=libgrpc++-dev BTW, we can use gRPC version detected by |
What about RHEL and similar? |
|
Then I agree we can require gRPC 1.30 or later. It won't simplify much, though ;-) |
We don't need to use `try_compile()` by using gRPC version detected by `find_package()`.
#36581) ### Rationale for this change We don't need to use `try_compile()` by using gRPC version detected by `find_package()`. ### What changes are included in this PR? Use gRPC version detected by `find_package()`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #36479 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the enhancement requested
Currently, we have a suite of compilation-based configuration tests to find out the approximate gRPC version, for feature selection.
Starting with 1.51.0 however, the gRPC C++ API exposes version macros:
grpc/grpc#31033
We could start using those and fallback on the older method if the macros are not available.
Component(s)
C++, FlightRPC
The text was updated successfully, but these errors were encountered: