Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB] Remove the DeepCopy name-value pair from arrow.array.<Numeric>Array constructors #36560

Closed
sgilmore10 opened this issue Jul 7, 2023 · 1 comment · Fixed by #36561
Closed

[MATLAB] Remove the DeepCopy name-value pair from arrow.array.<Numeric>Array constructors #36560

sgilmore10 opened this issue Jul 7, 2023 · 1 comment · Fixed by #36561
Assignees
@sgilmore10
Labels
Component: MATLAB Type: enhancement
Milestone
13.0.0

Comments

@sgilmore10
Copy link
Member

Describe the enhancement requested

We initially added the DeepCopy name-value pair to the numeric array class constructors for testing purposes. When DeepCopy=true, the proxy classes copy the data from the MATLAB array when creating the underlying std::shared_ptr<arrow::NumericArray<CType>>. By default, we don't make a copy and instead store the original array as property named MatlabArray.

Component(s)

MATLAB
@sgilmore10
Copy link
Member Author

take

@github-actions github-actions bot mentioned this issue Jul 7, 2023
Merged
kevingurney pushed a commit that referenced this issue Jul 10, 2023
@sgilmore10
GH-36560: [MATLAB] Remove the DeepCopy name-value pair from `arrow.ar…
5c4ba87 
…ray.<Numeric>Array` constructors (#36561)

### Rationale for this change

We initially added the `DeepCopy` name-value pair to the numeric array class constructors for testing purposes. When `DeepCopy=true`, the proxy classes copy the data from the MATLAB array when creating the underlying `std::shared_ptr<arrow::NumericArray<CType>>`. By default, we don't make a copy and instead store the original array as a property named `MatlabArray`. Doing so keeps the backing memory of the arrow array alive and avoids a copy.

### What changes are included in this PR?
`DeepCopy` is no longer accepted as a name-value pair by the constructors of the numeric array classes. 

### Are these changes tested?
No tests were needed.

### Are there any user-facing changes?

This is technically a user facing change, but the MATLAB interface is still experimental and under active development. We don't expect anyone to be affected by this change.

* Closes: #36560

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
@kevingurney kevingurney added this to the 13.0.0 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgilmore10 sgilmore10

Labels
Component: MATLAB Type: enhancement
Projects
None yet
Milestone
13.0.0
2 participants
@kevingurney @sgilmore10