Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Include Timestamp Zone in ValueStr output #36568

Closed
zeroshade opened this issue Jul 8, 2023 · 0 comments · Fixed by #36569
Closed

[Go] Include Timestamp Zone in ValueStr output #36568

zeroshade opened this issue Jul 8, 2023 · 0 comments · Fixed by #36569
Assignees
@zeroshade
Labels
Component: Go Type: enhancement
Milestone
13.0.0

Comments

@zeroshade
Copy link
Member

Describe the enhancement requested

for AppendValueFromString and ValueStr methods for the Timestamp array, the timezone information should be included and processed.

Component(s)

Go
zeroshade added a commit to zeroshade/arrow that referenced this issue Jul 8, 2023
@zeroshade
apacheGH-36568: [Go] Include Timestamp Zone in ValueStr
856f91c
@github-actions github-actions bot mentioned this issue Jul 8, 2023
Merged
zeroshade added a commit that referenced this issue Jul 10, 2023
@zeroshade
GH-36568: [Go] Include Timestamp Zone in ValueStr (#36569)
70f4476 
### Rationale for this change
While trying to fix an issue with Snowflake ADBC timestamp handling, I came across this as part of the problem.

### What changes are included in this PR?
Adds the timezone string indicator to the output of `ValueStr` for a timestamp array.

* Closes: #36568

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Jul 10, 2023
raulcd pushed a commit that referenced this issue Jul 11, 2023
@zeroshade @raulcd
GH-36568: [Go] Include Timestamp Zone in ValueStr (#36569)
608669f 
### Rationale for this change
While trying to fix an issue with Snowflake ADBC timestamp handling, I came across this as part of the problem.

### What changes are included in this PR?
Adds the timezone string indicator to the output of `ValueStr` for a timestamp array.

* Closes: #36568

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36568: [Go] Include Timestamp Zone in ValueStr zeroshade/arrow
1 participant
@zeroshade