Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Dev] ARROW_ACERO should be OFF by default in ci/scripts/cpp_build.sh #36610

Closed
pitrou opened this issue Jul 11, 2023 · 3 comments · Fixed by #36611
Closed

[C++][Dev] ARROW_ACERO should be OFF by default in ci/scripts/cpp_build.sh #36610

pitrou opened this issue Jul 11, 2023 · 3 comments · Fixed by #36611
Assignees
@kou
Labels
Component: C++ Type: bug
Milestone
14.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jul 11, 2023

Describe the bug, including details regarding any error messages, version, and platform.

As the title says. For some reason the CI C++ build script always enabled Acero by default...

(I also don't understand why it's enabled in the Ubuntu "minimal" builds)

Component(s)

C++
@pitrou
Copy link
Member Author

pitrou commented Jul 11, 2023

@kou

kou added a commit to kou/arrow that referenced this issue Jul 11, 2023
@kou
apacheGH-36610: [CI][C++] Don't enable ARROW_ACERO by default
6d439bd
kou added a commit to kou/arrow that referenced this issue Jul 11, 2023
@kou
apacheGH-36610: [CI][C++] Don't enable ARROW_ACERO by default
9f95224
@github-actions github-actions bot mentioned this issue Jul 11, 2023
Merged
@kou
Copy link
Member

kou commented Jul 11, 2023

It seems that the "minimal" means that "minimal" environment not "minimal" build.

@pitrou
Copy link
Member Author

pitrou commented Jul 11, 2023

I see.

kou added a commit to kou/arrow that referenced this issue Jul 13, 2023
@kou
apacheGH-36610: [CI][C++] Don't enable ARROW_ACERO by default
cbb8157
kou added a commit that referenced this issue Jul 14, 2023
@kou
GH-36610: [CI][C++] Don't enable ARROW_ACERO by default (#36611)
8245b21 
### Rationale for this change

Because it's not a required component.

### What changes are included in this PR?

Use `OFF` by default.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #36610

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Jul 14, 2023
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this issue Jul 20, 2023
@kou @chelseajonesr
apacheGH-36610: [CI][C++] Don't enable ARROW_ACERO by default (apache…
76b9587 
…#36611)

### Rationale for this change

Because it's not a required component.

### What changes are included in this PR?

Use `OFF` by default.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#36610

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@kou @R-JunmingChen
apacheGH-36610: [CI][C++] Don't enable ARROW_ACERO by default (apache…
2581f0e 
…#36611)

### Rationale for this change

Because it's not a required component.

### What changes are included in this PR?

Use `OFF` by default.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#36610

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36610: [CI][C++] Don't enable ARROW_ACERO by default kou/arrow
2 participants
@kou @pitrou