Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] array.Null type support handling for arrow/csv writing #36623

Closed
ggodik opened this issue Jul 12, 2023 · 1 comment · Fixed by #36624
Closed

[Go] array.Null type support handling for arrow/csv writing #36623

ggodik opened this issue Jul 12, 2023 · 1 comment · Fixed by #36624
Assignees
@ggodik
Labels
Component: Go Type: enhancement
Milestone
14.0.0

Comments

@ggodik
Copy link
Contributor

ggodik commented Jul 12, 2023

Describe the enhancement requested

Currently the array.Null type is not supported

  • validation panics if a NullType is present
  • Writer.transformColToStringArr lacks the handling

Enhancement to support writing nulls as it's already a CSV feature.

Component(s)

Go
@ggodik
Copy link
Contributor Author

ggodik commented Jul 12, 2023

PR forthcoming

ggodik pushed a commit to ggodik/arrow that referenced this issue Jul 12, 2023
apacheGH-36623: [Go] NullType support for csv
2ce9f6a
@github-actions github-actions bot mentioned this issue Jul 12, 2023
Merged
@zeroshade zeroshade changed the title [GO] array.Null type support handling for arrow/csv writing [Go] array.Null type support handling for arrow/csv writing Jul 12, 2023
zeroshade pushed a commit that referenced this issue Jul 12, 2023
@ggodik
GH-36623: [Go] NullType support for csv (#36624)
600013a 
### Rationale for this change

### What changes are included in this PR?

* adding `NullType` to `validate`
* NullType handling in `Writer.transformColToStringArr` to write an `nullValue`

### Are these changes tested?

Unit tests included in change

### Are there any user-facing changes?
 
No
* Closes: #36623

Authored-by: ggodik <ggodik@factset.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 13.0.0 milestone Jul 12, 2023
@github-actions github-actions bot mentioned this issue Jul 12, 2023
Merged
@raulcd raulcd modified the milestones: 13.0.0, 14.0.0 Jul 13, 2023
chelseajonesr pushed a commit to chelseajonesr/arrow that referenced this issue Jul 20, 2023
@ggodik @chelseajonesr
apacheGH-36623: [Go] NullType support for csv (apache#36624)
63c0a41 
### Rationale for this change

### What changes are included in this PR?

* adding `NullType` to `validate`
* NullType handling in `Writer.transformColToStringArr` to write an `nullValue`

### Are these changes tested?

Unit tests included in change

### Are there any user-facing changes?
 
No
* Closes: apache#36623

Authored-by: ggodik <ggodik@factset.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@ggodik @R-JunmingChen
apacheGH-36623: [Go] NullType support for csv (apache#36624)
ab63b01 
### Rationale for this change

### What changes are included in this PR?

* adding `NullType` to `validate`
* NullType handling in `Writer.transformColToStringArr` to write an `nullValue`

### Are these changes tested?

Unit tests included in change

### Are there any user-facing changes?
 
No
* Closes: apache#36623

Authored-by: ggodik <ggodik@factset.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggodik ggodik

Labels
Component: Go Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36623: [Go] NullType support for csv ggodik/arrow
3 participants
@ggodik @zeroshade @raulcd