[R] Error with create_package_with_all_dependencies() on Windows #36638
Comments
|
Thanks for reporting this @bpaull and for providing a solution as well. As you've said, it looks like we need to be escaping the path properly on Windows. |
|
Are you interested in submitting a PR @bpaull ? We always love to see new contributors to the project, and it sounds like this should be fairly straightforward for you to verify that your change has worked! |
thisisnic
added a commit
that referenced
this issue
Sep 25, 2023
…ndows (#37226) ### Rationale for this change Fix path to directory which stops `create_package_with_all_dependencies()` working on Windows ### What changes are included in this PR? Character replacement in the script to ensure that on Windows, wsl-comaptible path is used and paths are normalised. ### Are these changes tested? I tested it locally myself and it works - there are no tests for this function. ### Are there any user-facing changes? Nope * Closes: #36638 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
etseidl
pushed a commit
to etseidl/arrow
that referenced
this issue
Sep 28, 2023
… on Windows (apache#37226) ### Rationale for this change Fix path to directory which stops `create_package_with_all_dependencies()` working on Windows ### What changes are included in this PR? Character replacement in the script to ensure that on Windows, wsl-comaptible path is used and paths are normalised. ### Are these changes tested? I tested it locally myself and it works - there are no tests for this function. ### Are there any user-facing changes? Nope * Closes: apache#36638 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 23, 2023
… on Windows (apache#37226) ### Rationale for this change Fix path to directory which stops `create_package_with_all_dependencies()` working on Windows ### What changes are included in this PR? Character replacement in the script to ensure that on Windows, wsl-comaptible path is used and paths are normalised. ### Are these changes tested? I tested it locally myself and it works - there are no tests for this function. ### Are there any user-facing changes? Nope * Closes: apache#36638 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
… on Windows (apache#37226) ### Rationale for this change Fix path to directory which stops `create_package_with_all_dependencies()` working on Windows ### What changes are included in this PR? Character replacement in the script to ensure that on Windows, wsl-comaptible path is used and paths are normalised. ### Are these changes tested? I tested it locally myself and it works - there are no tests for this function. ### Are there any user-facing changes? Nope * Closes: apache#36638 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
… on Windows (apache#37226) ### Rationale for this change Fix path to directory which stops `create_package_with_all_dependencies()` working on Windows ### What changes are included in this PR? Character replacement in the script to ensure that on Windows, wsl-comaptible path is used and paths are normalised. ### Are these changes tested? I tested it locally myself and it works - there are no tests for this function. ### Are there any user-facing changes? Nope * Closes: apache#36638 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
When using
create_package_with_all_dependencies()On Windows 10 an error occur :Error : '\U' not followed by heaxadecimal code in "C:\U"
This error come from
source(download_script)line 38 and seem to be due to the path writen in the download script bysystem2("bash", c(download_dependencies_sh, download_dir), stdout = download_script, stderr = FALSE).rewriting double backslash seem to solve the problem :
system2("bash", c(download_dependencies_sh, gsub("\\", "/", download_dir, fixed = TRUE)), stdout = download_script, stderr = FALSE)Component(s)
R
The text was updated successfully, but these errors were encountered: