Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Use anonymous namespace in arrow/IPC/reader.cc #36674

Closed
smahapatra1 opened this issue Jul 13, 2023 · 6 comments · Fixed by #36937
Closed

[C++] Use anonymous namespace in arrow/IPC/reader.cc #36674

smahapatra1 opened this issue Jul 13, 2023 · 6 comments · Fixed by #36937
Assignees
@pegasas
Labels
Component: C++ good-first-issue
Milestone
14.0.0

Comments

@smahapatra1
Copy link

smahapatra1 commented Jul 13, 2023 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

It is technically not a bug, but the following types and functions should be in in file scope:

IpcReadConext, BatchDataReadRequest, ArrayLoader,
DecompressBuffer(s), LoadRecordBatch*, GetCompression*,
ReadRecordBatchInternal,
GetInclusionMaskAndOutSchmea, UnpackSchemaMessage,
ReadDictionary, AsyncRecordBatchStreamReaderImpl,

Component(s)

C++
@smahapatra1 smahapatra1 reopened this Jul 16, 2023
@smahapatra1 smahapatra1 changed the title Use anonymous namespace in arrow/IPC/writer.cc Use anonymous namespace in arrow/IPC/reader.cc Jul 16, 2023
@westonpace westonpace changed the title Use anonymous namespace in arrow/IPC/reader.cc [C++] Use anonymous namespace in arrow/IPC/reader.cc Jul 19, 2023
@westonpace
Copy link
Member

I agree this would be a good idea. Do you want to propose a PR?

@mfruttid
Copy link

I would like to contribute to this if that's fine

@smahapatra1
Copy link
Author

smahapatra1 commented Jul 28, 2023 via email

@pegasas
Copy link
Contributor

pegasas commented Jul 29, 2023

Thanks, will raise PR for tracking

@pegasas pegasas mentioned this issue Jul 30, 2023
Merged
pitrou added a commit that referenced this issue Aug 9, 2023
@pegasas @pitrou
GH-36674: [C++] Use anonymous namespace in arrow/ipc/reader.cc (#36937)
1a00fec 
### Rationale for this change

The following types and functions should be in file scope:

IpcReadConext, BatchDataReadRequest, ArrayLoader,
DecompressBuffer(s), LoadRecordBatch*, GetCompression*,
ReadRecordBatchInternal,
GetInclusionMaskAndOutSchmea, UnpackSchemaMessage,
ReadDictionary, AsyncRecordBatchStreamReaderImpl.

### What changes are included in this PR?

Use anonymous namespace around the aforementioned definitions.

### Are these changes tested?

No

### Are there any user-facing changes?

No

Lead-authored-by: pegasas <616672335@qq.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 14.0.0 milestone Aug 9, 2023
@pitrou
Copy link
Member

pitrou commented Aug 9, 2023

Issue resolved by pull request 36937
#36937

@pitrou pitrou closed this as completed Aug 9, 2023
@pegasas
Copy link
Contributor

pegasas commented Aug 9, 2023

Thanks @pitrou !

loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@pegasas @pitrou @loicalleyne
apacheGH-36674: [C++] Use anonymous namespace in arrow/ipc/reader.cc (a…
d180a9a 
…pache#36937)

### Rationale for this change

The following types and functions should be in file scope:

IpcReadConext, BatchDataReadRequest, ArrayLoader,
DecompressBuffer(s), LoadRecordBatch*, GetCompression*,
ReadRecordBatchInternal,
GetInclusionMaskAndOutSchmea, UnpackSchemaMessage,
ReadDictionary, AsyncRecordBatchStreamReaderImpl.

### What changes are included in this PR?

Use anonymous namespace around the aforementioned definitions.

### Are these changes tested?

No

### Are there any user-facing changes?

No

Lead-authored-by: pegasas <616672335@qq.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pegasas pegasas

Labels
Component: C++ good-first-issue
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36674: [C++] Use anonymous namespace in arrow/ipc/reader.cc
5 participants
@westonpace @pitrou @pegasas @smahapatra1 @mfruttid