Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB] Add TimeUnit and TimeZone to the arrow.type.TimestampType display #36735

Closed
sgilmore10 opened this issue Jul 17, 2023 · 1 comment · Fixed by #36871
Closed

[MATLAB] Add TimeUnit and TimeZone to the arrow.type.TimestampType display #36735

sgilmore10 opened this issue Jul 17, 2023 · 1 comment · Fixed by #36871
Assignees
@sgilmore10
Labels
Component: MATLAB Type: enhancement
Milestone
14.0.0

Comments

@sgilmore10
Copy link
Member

Describe the enhancement requested

Currently, the display for arrow.type.TimestampType does not show the TimeUnit or the TimeZone.

>> type = arrow.type.timestamp(TimeUnit="second", TimeZone="America/New_York")

type = 

  TimestampType with properties:

    ID: Timestamp

We should modify the display to show both TimeUnit and TimeZone.

Component(s)

MATLAB
@sgilmore10
Copy link
Member Author

take

@github-actions github-actions bot mentioned this issue Jul 25, 2023
Merged
kevingurney pushed a commit that referenced this issue Jul 26, 2023
@sgilmore10
GH-36735 : Add TimeUnit and TimeZone to the `arrow.type.Timestamp…
0513097 
…Type` display (#36871)

### Rationale for this change

The `arrow.type.TimestampType` display should include the `TimeUnit` and `TimeZone` properties. Right now we only display the `ID` property: 

```matlab
>> type = arrow.type.timestamp(TimeUnit="Second", TimeZone="America/Anchorage")

type = 

  TimestampType with properties:

    ID: Timestamp
```
We should show the other two properties in the display.

### What changes are included in this PR?

Modified the display of `TimestampType`:

```matlab
>> type = arrow.type.timestamp(TimeUnit="Second", TimeZone="America/Anchorage")

type = 

  TimestampType with properties:

          ID: Timestamp
    TimeUnit: Second
    TimeZone: "America/Anchorage"

```
Now `TimeUnit` and `TimeZone` are included.

### Are these changes tested?

Added a test case to `tTimestampType` called `Display`. It verifies `TimestampType` objects are displayed correctly in the Command Window.

### Are there any user-facing changes?

Yes, users will see the new display.

* Closes: #36735

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
@kevingurney kevingurney added this to the 14.0.0 milestone Jul 26, 2023
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@sgilmore10 @R-JunmingChen
apacheGH-36735 : Add TimeUnit and TimeZone to the `arrow.type.Tim…
7b86735 
…estampType` display (apache#36871)

### Rationale for this change

The `arrow.type.TimestampType` display should include the `TimeUnit` and `TimeZone` properties. Right now we only display the `ID` property: 

```matlab
>> type = arrow.type.timestamp(TimeUnit="Second", TimeZone="America/Anchorage")

type = 

  TimestampType with properties:

    ID: Timestamp
```
We should show the other two properties in the display.

### What changes are included in this PR?

Modified the display of `TimestampType`:

```matlab
>> type = arrow.type.timestamp(TimeUnit="Second", TimeZone="America/Anchorage")

type = 

  TimestampType with properties:

          ID: Timestamp
    TimeUnit: Second
    TimeZone: "America/Anchorage"

```
Now `TimeUnit` and `TimeZone` are included.

### Are these changes tested?

Added a test case to `tTimestampType` called `Display`. It verifies `TimestampType` objects are displayed correctly in the Command Window.

### Are there any user-facing changes?

Yes, users will see the new display.

* Closes: apache#36735

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@sgilmore10 @loicalleyne
apacheGH-36735 : Add TimeUnit and TimeZone to the `arrow.type.Tim…
487b518 
…estampType` display (apache#36871)

### Rationale for this change

The `arrow.type.TimestampType` display should include the `TimeUnit` and `TimeZone` properties. Right now we only display the `ID` property: 

```matlab
>> type = arrow.type.timestamp(TimeUnit="Second", TimeZone="America/Anchorage")

type = 

  TimestampType with properties:

    ID: Timestamp
```
We should show the other two properties in the display.

### What changes are included in this PR?

Modified the display of `TimestampType`:

```matlab
>> type = arrow.type.timestamp(TimeUnit="Second", TimeZone="America/Anchorage")

type = 

  TimestampType with properties:

          ID: Timestamp
    TimeUnit: Second
    TimeZone: "America/Anchorage"

```
Now `TimeUnit` and `TimeZone` are included.

### Are these changes tested?

Added a test case to `tTimestampType` called `Display`. It verifies `TimestampType` objects are displayed correctly in the Command Window.

### Are there any user-facing changes?

Yes, users will see the new display.

* Closes: apache#36735

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgilmore10 sgilmore10

Labels
Component: MATLAB Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36735: [MATLAB] Add TimeUnit and TimeZone to the arrow.type.TimestampType display mathworks/arrow
2 participants
@kevingurney @sgilmore10