Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][Flight] Expose the underlying Flight Protobuf Objects #36893

Closed
zeroshade opened this issue Jul 26, 2023 · 0 comments · Fixed by #36895
Closed

[Go][Flight] Expose the underlying Flight Protobuf Objects #36893

zeroshade opened this issue Jul 26, 2023 · 0 comments · Fixed by #36895
Assignees
@zeroshade
Labels
Component: FlightRPC Component: Go go Pull requests that update Go code Type: enhancement
Milestone
14.0.0

Comments

@zeroshade
Copy link
Member

Describe the enhancement requested

For users with uncommon use cases it is important that we at least expose/export the underlying Flight and FlightSQL generated protobuf code so that users won't need to generate it themselves and deal with the potential conflicts.

Component(s)

FlightRPC, Go
@zeroshade zeroshade added Type: enhancement Component: FlightRPC go Pull requests that update Go code labels Jul 26, 2023
@zeroshade zeroshade self-assigned this Jul 26, 2023
zeroshade added a commit to zeroshade/arrow that referenced this issue Jul 26, 2023
@zeroshade
apacheGH-36893: [Go][Flight] Expose underlying protobuf definitions
683ea6c
@github-actions github-actions bot mentioned this issue Jul 26, 2023
Merged
zeroshade added a commit that referenced this issue Jul 26, 2023
@zeroshade
GH-36893: [Go][Flight] Expose underlying protobuf definitions (#36895)
7c0451c 
### What changes are included in this PR?
Shifting generated protobuf code for flight/flightsql to have the path `arrow/flight/gen/flight` rather than `arrow/flight/internal/flight` so that they are exposed and exported.

* Closes: #36893

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 14.0.0 milestone Jul 26, 2023
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@zeroshade @R-JunmingChen
apacheGH-36893: [Go][Flight] Expose underlying protobuf definitions (a…
98df0f9 
…pache#36895)

### What changes are included in this PR?
Shifting generated protobuf code for flight/flightsql to have the path `arrow/flight/gen/flight` rather than `arrow/flight/internal/flight` so that they are exposed and exported.

* Closes: apache#36893

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@zeroshade @loicalleyne
apacheGH-36893: [Go][Flight] Expose underlying protobuf definitions (a…
b37ac52 
…pache#36895)

### What changes are included in this PR?
Shifting generated protobuf code for flight/flightsql to have the path `arrow/flight/gen/flight` rather than `arrow/flight/internal/flight` so that they are exposed and exported.

* Closes: apache#36893

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: FlightRPC Component: Go go Pull requests that update Go code Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36893: [Go][Flight] Expose underlying protobuf definitions zeroshade/arrow
1 participant
@zeroshade