Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add support for SparseUnion to selection functions #36905

Closed
js8544 opened this issue Jul 27, 2023 · 0 comments · Fixed by #36906
Closed

[C++] Add support for SparseUnion to selection functions #36905

js8544 opened this issue Jul 27, 2023 · 0 comments · Fixed by #36906
Assignees
@js8544
Labels
Component: C++ Type: enhancement
Milestone
14.0.0

Comments

@js8544
Copy link
Collaborator

js8544 commented Jul 27, 2023

Describe the enhancement requested

Dense unions are already supported in Take, Filter and DropNull but sparse ones are not.

Component(s)

C++
js8544 added a commit to js8544/arrow that referenced this issue Jul 27, 2023
@js8544
apacheGH-36905: selection functions support sparse union
cba22d6
@js8544 js8544 changed the title [C++] Add support for SparseUnion in selection functions [C++] Add support for SparseUnion to selection functions Jul 27, 2023
@github-actions github-actions bot mentioned this issue Jul 27, 2023
Merged
@pitrou pitrou added this to the 14.0.0 milestone Aug 10, 2023
pitrou added a commit that referenced this issue Aug 10, 2023
@js8544 @pitrou
GH-36905: [C++] Add support for SparseUnion to selection functions (#…
ebcf7bc 
…36906)

### Rationale for this change

Dense unions are already supported in Take, Filter and DropNull but sparse ones are not.

### What changes are included in this PR?

Add kernels for sparse unions to those functions.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No. 

* Closes: #36905

Lead-authored-by: Jin Shang <shangjin1997@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@js8544 @pitrou @loicalleyne
apacheGH-36905: [C++] Add support for SparseUnion to selection functi…
1e5c528 
…ons (apache#36906)

### Rationale for this change

Dense unions are already supported in Take, Filter and DropNull but sparse ones are not.

### What changes are included in this PR?

Add kernels for sparse unions to those functions.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No. 

* Closes: apache#36905

Lead-authored-by: Jin Shang <shangjin1997@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@js8544 js8544

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36905: [C++] Add support for SparseUnion to selection functions js8544/arrow
2 participants
@pitrou @js8544