Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][C++][Windows] Can't find OpenSSL on GitHub Actions #36922

Closed
kou opened this issue Jul 28, 2023 · 0 comments · Fixed by #36923
Closed

[CI][C++][Windows] Can't find OpenSSL on GitHub Actions #36922

kou opened this issue Jul 28, 2023 · 0 comments · Fixed by #36923
Assignees
@kou
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
14.0.0

Comments

@kou
Copy link
Member

kou commented Jul 28, 2023

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/apache/arrow/actions/runs/5677888670/job/15387011696#step:11:296

-- Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY OPENSSL_INCLUDE_DIR) (Required is at least version "1.0.2")

It seems that this is related to GitHub Actions Windows image update.

Component(s)

C++, Continuous Integration
@kou kou added the Type: bug label Jul 28, 2023
kou added a commit to kou/arrow that referenced this issue Jul 28, 2023
@kou
apacheGH-36922: [CI][C++][Windows] Search OpenSSL from PATH
1bfc705 
Instead of specifying OPENSSL_ROOT_DIR explicitly.
It seems that OpenSSL install script adds the OpenSSL install folder
to PATH: https://github.com/actions/runner-images/blob/665e71067ff126acea71e7d93715c83db038597f/images/win/scripts/Installers/Install-OpenSSL.ps1#L37
@github-actions github-actions bot mentioned this issue Jul 28, 2023
Merged
kou added a commit that referenced this issue Jul 28, 2023
@kou
GH-36922: [CI][C++][Windows] Search OpenSSL from PATH (#36923)
5b744ab 
### Rationale for this change

It seems that OpenSSL install script adds the OpenSSL install folder to `PATH`:
https://github.com/actions/runner-images/blob/665e71067ff126acea71e7d93715c83db038597f/images/win/scripts/Installers/Install-OpenSSL.ps1#L37

If OpenSSL install folder exists in `PATH`, we don't need to specify `OPENSSL_ROOT_DIR` explicitly. Because `find_*` such as [`find_library()`](https://cmake.org/cmake/help/latest/command/find_library.html) searches path in `PATH` by default:

> On Windows hosts: `<prefix>/lib/<arch>` if [`CMAKE_LIBRARY_ARCHITECTURE`](https://cmake.org/cmake/help/latest/variable/CMAKE_LIBRARY_ARCHITECTURE.html#variable:CMAKE_LIBRARY_ARCHITECTURE) is set, and `<prefix>/lib` for each `<prefix>/[s]bin` in `PATH`, and `<entry>/lib` for other entries in `PATH`.

### What changes are included in this PR?

Remove `OPENSSL_ROOT_DIR`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #36922

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Jul 28, 2023
R-JunmingChen pushed a commit to R-JunmingChen/arrow that referenced this issue Aug 20, 2023
@kou @R-JunmingChen
apacheGH-36922: [CI][C++][Windows] Search OpenSSL from PATH (apache#3…
2b14f50 
…6923)

### Rationale for this change

It seems that OpenSSL install script adds the OpenSSL install folder to `PATH`:
https://github.com/actions/runner-images/blob/665e71067ff126acea71e7d93715c83db038597f/images/win/scripts/Installers/Install-OpenSSL.ps1#L37

If OpenSSL install folder exists in `PATH`, we don't need to specify `OPENSSL_ROOT_DIR` explicitly. Because `find_*` such as [`find_library()`](https://cmake.org/cmake/help/latest/command/find_library.html) searches path in `PATH` by default:

> On Windows hosts: `<prefix>/lib/<arch>` if [`CMAKE_LIBRARY_ARCHITECTURE`](https://cmake.org/cmake/help/latest/variable/CMAKE_LIBRARY_ARCHITECTURE.html#variable:CMAKE_LIBRARY_ARCHITECTURE) is set, and `<prefix>/lib` for each `<prefix>/[s]bin` in `PATH`, and `<entry>/lib` for other entries in `PATH`.

### What changes are included in this PR?

Remove `OPENSSL_ROOT_DIR`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#36922

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-36922: [CI][C++][Windows] Search OpenSSL from PATH (apache#3…
3e9b623 
…6923)

### Rationale for this change

It seems that OpenSSL install script adds the OpenSSL install folder to `PATH`:
https://github.com/actions/runner-images/blob/665e71067ff126acea71e7d93715c83db038597f/images/win/scripts/Installers/Install-OpenSSL.ps1#L37

If OpenSSL install folder exists in `PATH`, we don't need to specify `OPENSSL_ROOT_DIR` explicitly. Because `find_*` such as [`find_library()`](https://cmake.org/cmake/help/latest/command/find_library.html) searches path in `PATH` by default:

> On Windows hosts: `<prefix>/lib/<arch>` if [`CMAKE_LIBRARY_ARCHITECTURE`](https://cmake.org/cmake/help/latest/variable/CMAKE_LIBRARY_ARCHITECTURE.html#variable:CMAKE_LIBRARY_ARCHITECTURE) is set, and `<prefix>/lib` for each `<prefix>/[s]bin` in `PATH`, and `<entry>/lib` for other entries in `PATH`.

### What changes are included in this PR?

Remove `OPENSSL_ROOT_DIR`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#36922

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36922: [CI][C++][Windows] Search OpenSSL from PATH kou/arrow
1 participant
@kou