Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Compute] Add cumulative_mean function #36931

Closed
js8544 opened this issue Jul 28, 2023 · 0 comments · Fixed by #36932
Closed

[C++][Compute] Add cumulative_mean function #36931

js8544 opened this issue Jul 28, 2023 · 0 comments · Fixed by #36932
Assignees
@js8544
Labels
Component: C++ Type: enhancement
Milestone
14.0.0

Comments

@js8544
Copy link
Collaborator

js8544 commented Jul 28, 2023

Describe the enhancement requested

Add a cumulative mean function

Component(s)

C++
@github-actions github-actions bot mentioned this issue Jul 28, 2023
Merged
js8544 added a commit to js8544/arrow that referenced this issue Jul 28, 2023
@js8544
apacheGH-36931: [C++] Add cumulative_mean function
35ba81a
pitrou added a commit that referenced this issue Aug 9, 2023
@js8544 @pitrou
GH-36931: [C++] Add cumulative_mean function (#36932)
6e6e6f0 
### Rationale for this change

Add `cumulative_mean` function

### What changes are included in this PR?

Implement `cumulative_mean` function. The current cumulative_* kernel generator can only be based on a simple binary arithmetic op and the state can only be a single value. I refactored it to using of a generic state such that it can handle complex operations such as `mean`, `median`, `var` etc.

### Are these changes tested?

Yes

### Are there any user-facing changes?
No

* Closes: #36931

Lead-authored-by: Jin Shang <shangjin1997@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 14.0.0 milestone Aug 9, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@js8544 @pitrou @loicalleyne
apacheGH-36931: [C++] Add cumulative_mean function (apache#36932)
6eb31c9 
### Rationale for this change

Add `cumulative_mean` function

### What changes are included in this PR?

Implement `cumulative_mean` function. The current cumulative_* kernel generator can only be based on a simple binary arithmetic op and the state can only be a single value. I refactored it to using of a generic state such that it can handle complex operations such as `mean`, `median`, `var` etc.

### Are these changes tested?

Yes

### Are there any user-facing changes?
No

* Closes: apache#36931

Lead-authored-by: Jin Shang <shangjin1997@gmail.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@js8544 js8544

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-36931: [C++] Add cumulative_mean function js8544/arrow
2 participants
@pitrou @js8544