Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Documentation for read_parquet() et al needs updating #37019

Closed
thisisnic opened this issue Aug 3, 2023 · 2 comments · Fixed by #37020
Closed

[R] Documentation for read_parquet() et al needs updating #37019

thisisnic opened this issue Aug 3, 2023 · 2 comments · Fixed by #37020
Assignees
@thisisnic
Labels
Component: R Priority: Critical Type: bug
Milestone
13.0.0

Comments

@thisisnic
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

#35173 results in the read_*() family of functions now always returning tibbles, but the docs still say data.frame() - we should also cherry-pick the fix for this into 13.0.0 and make sure it's reflected on the deployed Arrow site

Component(s)

R
@thisisnic thisisnic self-assigned this Aug 3, 2023
@github-actions github-actions bot mentioned this issue Aug 3, 2023
Merged
@assignUser assignUser added this to the 13.0.0 milestone Aug 7, 2023
@assignUser
Copy link
Member

I have added the breaking change label to #35173 and added the 13 milestone to make sure it get's added to the next rc
cc @raulcd

@thisisnic
Copy link
Member Author

Thanks very much @assignUser !

thisisnic added a commit that referenced this issue Aug 9, 2023
@thisisnic
GH-37019: [R] Documentation for read_parquet() et al needs updating (#…
2972e49 
…37020)

### Rationale for this change

Docs were out of data with code after previous changes to returned object type

### What changes are included in this PR?

Update docs to reflect correct return type

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: #37019

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
raulcd pushed a commit that referenced this issue Aug 16, 2023
@thisisnic @raulcd
GH-37019: [R] Documentation for read_parquet() et al needs updating (#…
594b746 
…37020)

### Rationale for this change

Docs were out of data with code after previous changes to returned object type

### What changes are included in this PR?

Update docs to reflect correct return type

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: #37019

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@thisisnic @loicalleyne
apacheGH-37019: [R] Documentation for read_parquet() et al needs upda…
1950832 
…ting (apache#37020)

### Rationale for this change

Docs were out of data with code after previous changes to returned object type

### What changes are included in this PR?

Update docs to reflect correct return type

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37019

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnic thisisnic

Labels
Component: R Priority: Critical Type: bug
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-37019: [R] Documentation for read_parquet() et al needs updating thisisnic/arrow
2 participants
@thisisnic @assignUser