Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Missing kernel for coalesce with duration types #37028

Closed
spenczar opened this issue Aug 4, 2023 · 0 comments · Fixed by #37064
Closed

[C++] Missing kernel for coalesce with duration types #37028

spenczar opened this issue Aug 4, 2023 · 0 comments · Fixed by #37064

Comments

@spenczar
Copy link
Contributor

spenczar commented Aug 4, 2023

Describe the enhancement requested

coalesce (and so its callers, like PyArrow's fill_null) does not have a kernel implemented for Duration types. This is a pretty core function which would be helpful when working with Duration data. I currently use plain old integer types because of this limitation.

Component(s)

C++

js8544 added a commit to js8544/arrow that referenced this issue Aug 8, 2023
pitrou pushed a commit that referenced this issue Aug 14, 2023
…37064)

### Rationale for this change

Support for duration types is missing in if else functions, including if_else, coalesce, choose and case_when.

### What changes are included in this PR?
Add support for duration types to these functions.

### Are these changes tested?
Yes.

### Are there any user-facing changes?

No.

* Closes: #37028

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 14.0.0 milestone Aug 14, 2023
@kou kou changed the title Missing kernel for coalesce with duration types [C++] Missing kernel for coalesce with duration types Aug 15, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…ions (apache#37064)

### Rationale for this change

Support for duration types is missing in if else functions, including if_else, coalesce, choose and case_when.

### What changes are included in this PR?
Add support for duration types to these functions.

### Are these changes tested?
Yes.

### Are there any user-facing changes?

No.

* Closes: apache#37028

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants