[MATLAB] Update feather Reader and Writer objects to work directly with arrow.tabular.RecordBatchs instead of MATLAB tables
#37049
Comments
kevingurney
changed the title
Reader and Writer objects to work directly with arrow.tabular.RecordBatchs instead of MATLAB tables Reader and Writer objects to work directly with arrow.tabular.RecordBatchs instead of MATLAB tables
kevingurney
added a commit
that referenced
this issue
Aug 7, 2023
…rk directly with `arrow.tabular.RecordBatch`s instead of MATLAB `table`s (#37052) ### Rationale for this change After thinking about how to re-implement `featherread` and `featherwrite`, we realized it would be better if the `Reader` and `Writer` classes worked directly with `arrow.tabular.RecordBatch`s instead of MATLAB `table`s. ### What changes are included in this PR? 1. Updated `read` method of `arrow.internal.io.feather.Reader` to return an `arrow.tabular.RecordBatch` rather than a MATLAB `table`. 2. Updated `write` method of `arrow.internal.io.feather.Writer` to accept an `arrow.tabular.RecordBatch` rather than a MATLAB `table`. ### Are these changes tested? Yes. 1. Updated `feather/tRoundTrip.m` to reflect the changes to the `Reader` and `Writer` classes. ### Are there any user-facing changes? 1. No These are internal APIs. * Closes: #37049 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
… to work directly with `arrow.tabular.RecordBatch`s instead of MATLAB `table`s (apache#37052) ### Rationale for this change After thinking about how to re-implement `featherread` and `featherwrite`, we realized it would be better if the `Reader` and `Writer` classes worked directly with `arrow.tabular.RecordBatch`s instead of MATLAB `table`s. ### What changes are included in this PR? 1. Updated `read` method of `arrow.internal.io.feather.Reader` to return an `arrow.tabular.RecordBatch` rather than a MATLAB `table`. 2. Updated `write` method of `arrow.internal.io.feather.Writer` to accept an `arrow.tabular.RecordBatch` rather than a MATLAB `table`. ### Are these changes tested? Yes. 1. Updated `feather/tRoundTrip.m` to reflect the changes to the `Reader` and `Writer` classes. ### Are there any user-facing changes? 1. No These are internal APIs. * Closes: apache#37049 Authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
After thinking about how to re-implement
featherreadandfeatherwrite, we realized it would be better if theReaderandWriterclasses worked directly witharrow.tabular.RecordBatchs instead of MATLABtables.Component(s)
MATLAB
The text was updated successfully, but these errors were encountered: