Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] arrow-compute-scalar-round-benchmark fails with Rounding to -5 digits is out of range for type int16 #37106

Closed
jgehrcke opened this issue Aug 10, 2023 · 2 comments · Fixed by #37109
Closed

[C++] arrow-compute-scalar-round-benchmark fails with Rounding to -5 digits is out of range for type int16 #37106

jgehrcke opened this issue Aug 10, 2023 · 2 comments · Fixed by #37109
Assignees
@js8544
Labels
Component: Benchmarking Component: C++ Type: bug
Milestone
14.0.0

Comments

@jgehrcke
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

In benchmarking pipelines we see that arrow-compute-scalar-round-benchmark fails with code 6, emitting Invalid: Rounding to -5 digits is out of range for type int16 on stderr. The first commit that produces this error was 7c8f398. It seems to be strongly related :).

Component(s)

Archery, Benchmarking
@pitrou pitrou changed the title arrow-compute-scalar-round-benchmark fails with Rounding to -5 digits is out of range for type int16 [C++] arrow-compute-scalar-round-benchmark fails with Rounding to -5 digits is out of range for type int16 Aug 10, 2023
@pitrou
Copy link
Member

pitrou commented Aug 10, 2023

@js8544 Could you perhaps take a look?

@austin3dickey austin3dickey mentioned this issue Aug 10, 2023
Closed
@js8544
Copy link
Collaborator

js8544 commented Aug 10, 2023 •
edited
Loading

@js8544 Could you perhaps take a look?

The easiest fix I can think of is to remove the benchmark for uint8, int8, uint16 and int16 types. I think the 32 and 64 bits are good enough to represent integers since they are the most commonly used types. Does it sound good to you? @pitrou

@github-actions github-actions bot mentioned this issue Aug 10, 2023
Merged
pitrou pushed a commit that referenced this issue Aug 10, 2023
@js8544
GH-37106: [C++] Remove overflowed integer rounding benchmarks (#37109)
f0904b3 
### Rationale for this change

The valid range of 8 and 16 bit integers is too small, which causes failures on `round` benchmarks.

### What changes are included in this PR?

`Round` benchmarks for <32 bit integers are removed. Arithmetic on small int widths is probably uncommon.

### Are these changes tested?

The benchmark is now running successfully on my machine.

### Are there any user-facing changes?

No.

* Closes: #37106

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 14.0.0 milestone Aug 10, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@js8544 @loicalleyne
apacheGH-37106: [C++] Remove overflowed integer rounding benchmarks (a…
d9fdb0a 
…pache#37109)

### Rationale for this change

The valid range of 8 and 16 bit integers is too small, which causes failures on `round` benchmarks.

### What changes are included in this PR?

`Round` benchmarks for <32 bit integers are removed. Arithmetic on small int widths is probably uncommon.

### Are these changes tested?

The benchmark is now running successfully on my machine.

### Are there any user-facing changes?

No.

* Closes: apache#37106

Authored-by: Jin Shang <shangjin1997@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@js8544 js8544

Labels
Component: Benchmarking Component: C++ Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37106: [C++] Remove overflowed integer rounding benchmarks js8544/arrow
3 participants
@jgehrcke @pitrou @js8544