Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] support boolean columns with bitsize 1 in from_dataframe #37145

Closed
AlenkaF opened this issue Aug 14, 2023 · 0 comments · Fixed by #37975
Closed

[Python] support boolean columns with bitsize 1 in from_dataframe #37145

AlenkaF opened this issue Aug 14, 2023 · 0 comments · Fixed by #37975
Assignees
@AlenkaF
Labels
Component: Python Type: enhancement
Milestone
14.0.0

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Aug 14, 2023

Describe the enhancement requested

Add support for boolean columns with bitsize 1 in the from_dataframe function of the Dataframe Interchange Protocol implementation.

See: #33982 (comment)

Component(s)

Python
@AlenkaF AlenkaF self-assigned this Oct 2, 2023
@github-actions github-actions bot mentioned this issue Oct 2, 2023
Merged
AlenkaF added a commit to AlenkaF/arrow that referenced this issue Oct 5, 2023
@AlenkaF
Merge branch 'main' into apachegh-37145-bit-packed-boolean-from_dataf…
0e882f7 
…rame
AlenkaF added a commit that referenced this issue Oct 5, 2023
@AlenkaF
GH-37145: [Python] support boolean columns with bitsize 1 in from_dat…
161510e 
…aframe (#37975)

### Rationale for this change

Bit-packed booleans are currently not supported in the `from_dataframe` of the Dataframe Interchange Protocol.

Note: We currently represent booleans in the pyarrow implementation as `uint8` which will also need to be changed in a follow-up PR (see data-apis/dataframe-api#227). 

### What changes are included in this PR?

This PR adds the support for bit-packed booleans when consuming a dataframe interchange object.

### Are these changes tested?

Only locally, currently!
* Closes: #37145

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
@AlenkaF AlenkaF added this to the 14.0.0 milestone Oct 5, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@AlenkaF
apacheGH-37145: [Python] support boolean columns with bitsize 1 in fr…
1454856 
…om_dataframe (apache#37975)

### Rationale for this change

Bit-packed booleans are currently not supported in the `from_dataframe` of the Dataframe Interchange Protocol.

Note: We currently represent booleans in the pyarrow implementation as `uint8` which will also need to be changed in a follow-up PR (see data-apis/dataframe-api#227). 

### What changes are included in this PR?

This PR adds the support for bit-packed booleans when consuming a dataframe interchange object.

### Are these changes tested?

Only locally, currently!
* Closes: apache#37145

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@AlenkaF @loicalleyne
apacheGH-37145: [Python] support boolean columns with bitsize 1 in fr…
b713ab7 
…om_dataframe (apache#37975)

### Rationale for this change

Bit-packed booleans are currently not supported in the `from_dataframe` of the Dataframe Interchange Protocol.

Note: We currently represent booleans in the pyarrow implementation as `uint8` which will also need to be changed in a follow-up PR (see data-apis/dataframe-api#227). 

### What changes are included in this PR?

This PR adds the support for bit-packed booleans when consuming a dataframe interchange object.

### Are these changes tested?

Only locally, currently!
* Closes: apache#37145

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@AlenkaF @dgreiss
apacheGH-37145: [Python] support boolean columns with bitsize 1 in fr…
37fb2be 
…om_dataframe (apache#37975)

### Rationale for this change

Bit-packed booleans are currently not supported in the `from_dataframe` of the Dataframe Interchange Protocol.

Note: We currently represent booleans in the pyarrow implementation as `uint8` which will also need to be changed in a follow-up PR (see data-apis/dataframe-api#227). 

### What changes are included in this PR?

This PR adds the support for bit-packed booleans when consuming a dataframe interchange object.

### Are these changes tested?

Only locally, currently!
* Closes: apache#37145

Lead-authored-by: AlenkaF <frim.alenka@gmail.com>
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: Python Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37145: [Python] support boolean columns with bitsize 1 in from_dataframe AlenkaF/arrow
1 participant
@AlenkaF