Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] REE arrays aren't supported in the C bridge API #37173

Closed
felipecrv opened this issue Aug 15, 2023 · 0 comments · Fixed by #37174
Closed

[C++] REE arrays aren't supported in the C bridge API #37173

felipecrv opened this issue Aug 15, 2023 · 0 comments · Fixed by #37174
Assignees
@felipecrv
Labels
Component: C++ Type: bug
Milestone
14.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

As noticed here duckdb/duckdb#8249 (comment)

Component(s)

C++
@felipecrv felipecrv self-assigned this Aug 15, 2023
@github-actions github-actions bot mentioned this issue Aug 15, 2023
Merged
2 tasks
zeroshade added a commit that referenced this issue Aug 24, 2023
@felipecrv @zeroshade
GH-37173: [C++][Go][Format] C-export/import Run-End Encoded Arrays (#…
9958896 
…37174)

### Rationale for this change

All array types should be C-exportable.

It uses `"+r"` as the format string. `+` because it's a nested format and `r` was not taken and seems like the obvious choice.

### What changes are included in this PR?

- [x] Ability to C-import/expor REE arrays.
- [x] Reference update

### Are these changes tested?

Yes.
* Closes: #37173

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 14.0.0 milestone Aug 24, 2023
@czentgr czentgr mentioned this issue Nov 6, 2023
Closed
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@felipecrv @zeroshade @loicalleyne
apacheGH-37173: [C++][Go][Format] C-export/import Run-End Encoded Arr…
aeda02e 
…ays (apache#37174)

### Rationale for this change

All array types should be C-exportable.

It uses `"+r"` as the format string. `+` because it's a nested format and `r` was not taken and seems like the obvious choice.

### What changes are included in this PR?

- [x] Ability to C-import/expor REE arrays.
- [x] Reference update

### Are these changes tested?

Yes.
* Closes: apache#37173

Lead-authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Co-authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37173: [C++][Go][Format] C-export/import Run-End Encoded Arrays felipecrv/arrow
2 participants
@felipecrv @zeroshade