Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MATLAB] Add a test utility that creates a MATLAB table containing all supported types #37179

Closed
sgilmore10 opened this issue Aug 15, 2023 · 0 comments · Fixed by #37191
Closed

[MATLAB] Add a test utility that creates a MATLAB table containing all supported types #37179

sgilmore10 opened this issue Aug 15, 2023 · 0 comments · Fixed by #37191
Assignees
@sgilmore10
Labels
Component: MATLAB Type: enhancement
Milestone
14.0.0

Comments

@sgilmore10
Copy link
Member

Describe the enhancement requested

Add a test utility for creating a MATLAB table with all the types we support converting into arrow arrays.

Component(s)

MATLAB
@sgilmore10 sgilmore10 mentioned this issue Aug 15, 2023
Merged
@sgilmore10 sgilmore10 changed the title Add a test utility for creating a MATLAB table with all the types we support converting into arrow arrays Add a test utility for creating a MATLAB table with all the MATLAB types that are supported for for conversion to arrow arrays Aug 15, 2023
@sgilmore10 sgilmore10 changed the title Add a test utility for creating a MATLAB table with all the MATLAB types that are supported for for conversion to arrow arrays Add a test utility that creates a MATLAB table containing all supported types Aug 15, 2023
@github-actions github-actions bot mentioned this issue Aug 15, 2023
Merged
@kou kou changed the title Add a test utility that creates a MATLAB table containing all supported types [MATLAB] Add a test utility that creates a MATLAB table containing all supported types Aug 15, 2023
kou pushed a commit that referenced this issue Aug 15, 2023
@sgilmore10
GH-37179: [MATLAB] Add a test utility that creates a MATLAB table c…
01a9f72 
…ontaining all supported types (#37191)

### Rationale for this change

It would be helpful it we had a test utility that created a MATLAB `table` containing all the supported types. This would help avoid code duplication in our tests.

### What changes are included in this PR?

1. Added a new utility named `arrow.internal.test.tabular.createTableWithSupportedTypes()`
2. Updated `tRecordBatch.m` to use this utility.
3. Updated `tfeather.m` to use this utility.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.

* Closes: #37179

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Aug 15, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@sgilmore10 @loicalleyne
apacheGH-37179: [MATLAB] Add a test utility that creates a MATLAB `ta…
c870217 
…ble` containing all supported types (apache#37191)

### Rationale for this change

It would be helpful it we had a test utility that created a MATLAB `table` containing all the supported types. This would help avoid code duplication in our tests.

### What changes are included in this PR?

1. Added a new utility named `arrow.internal.test.tabular.createTableWithSupportedTypes()`
2. Updated `tRecordBatch.m` to use this utility.
3. Updated `tfeather.m` to use this utility.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.

* Closes: apache#37179

Authored-by: Sarah Gilmore <sgilmore@mathworks.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgilmore10 sgilmore10

Labels
Component: MATLAB Type: enhancement
Projects
None yet
Milestone
14.0.0
2 participants
@kou @sgilmore10