-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++] Primitive concrete arrays could expose a span converter #37199
Comments
@jsjtxietian would you like to add this? |
Will do. |
@jsjtxietian - Was this done / is this task still open? |
@chrisjordansquire Hi this task is still open. I went to one month vacation rightly after I took the task. I will do this likely before October. |
What about null values? |
They would not be exposed here. The semantics would be similar to |
felipecrv
pushed a commit
that referenced
this issue
Dec 18, 2023
) ### Rationale for this change Convenience. We can have such a helper at the buffer and array data level. ### What changes are included in this PR? Add `Buffer::span_as`, `Buffer::mutuable_span_as` and `ArraySpan::GetSpan`. ### Are these changes tested? No, but I'm happy to add some test if needed. ### Are there any user-facing changes? Yes, new public functions. * Closes: #37199 Authored-by: jsjtxietian <jsjtxietian@outlook.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this issue
Jan 23, 2024
apache#38027) ### Rationale for this change Convenience. We can have such a helper at the buffer and array data level. ### What changes are included in this PR? Add `Buffer::span_as`, `Buffer::mutuable_span_as` and `ArraySpan::GetSpan`. ### Are these changes tested? No, but I'm happy to add some test if needed. ### Are there any user-facing changes? Yes, new public functions. * Closes: apache#37199 Authored-by: jsjtxietian <jsjtxietian@outlook.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
apache#38027) ### Rationale for this change Convenience. We can have such a helper at the buffer and array data level. ### What changes are included in this PR? Add `Buffer::span_as`, `Buffer::mutuable_span_as` and `ArraySpan::GetSpan`. ### Are these changes tested? No, but I'm happy to add some test if needed. ### Are there any user-facing changes? Yes, new public functions. * Closes: apache#37199 Authored-by: jsjtxietian <jsjtxietian@outlook.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Just like we have
PrimitiveArray::raw_values
, we could also have something that returns aarrow::util::span
for easier consumption:Component(s)
C++
The text was updated successfully, but these errors were encountered: